View Bazaar branches
Get this repository:
git clone https://git.launchpad.net/lttng-ust

See all merge proposals.

Import details

Import Status: Reviewed

This repository is an import of the Git repository at git://git.lttng.org/lttng-ust.git.

The next import is scheduled to run .

Last successful import was .

Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 10 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-14 and finished taking 15 seconds — see the log
Import started on juju-1e3bde-prod-lp-code-import-13 and finished taking 15 seconds — see the log

Branches

Name Last Modified Last Commit
stable-2.12 2022-06-27 14:38:25 UTC
Fix: Use negative value for error code of lttng_ust_ctl_duplicate_ust_object_...

Author: takeshi.iwanari
Author Date: 2022-06-24 13:17:39 UTC

Fix: Use negative value for error code of lttng_ust_ctl_duplicate_ust_object_data

[As is]
  - `lttng_ust_ctl_duplicate_ust_object_data` function is called by the following functions:
    - `event_notifier_error_accounting_register_app` (lttng-tools)
    - `duplicate_stream_object` (lttng-tools)
    - `duplicate_channel_object` (lttng-tools)
  - `lttng_ust_ctl_duplicate_ust_object_data` function returns positive value (= errno = 24 = EMFILE) when system call `dup` returns error
  - However, `duplicate_stream_object` and `duplicate_channel_object` functions expect negative value as error code
  - As a result, these functions cannot handle error and segmentation fault occurs when using `stream->handle`

[Proposal]
  - Currently, `lttng_ust_ctl_duplicate_ust_object_data` function returns either positive or negative value when error happens
  - It looks convention is using negative value for error code (e.g. `-ENOMEM` )
  - So, I propose to change `errno` to `-errno`

Signed-off-by: takeshi.iwanari <takeshi.iwanari@tier4.jp>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: Iccb01930413ecd5a8c58ad267e9c4eca53694dc7

stable-2.13 2022-06-27 14:37:20 UTC
Fix: Use negative value for error code of lttng_ust_ctl_duplicate_ust_object_...

Author: takeshi.iwanari
Author Date: 2022-06-24 13:17:39 UTC

Fix: Use negative value for error code of lttng_ust_ctl_duplicate_ust_object_data

[As is]
  - `lttng_ust_ctl_duplicate_ust_object_data` function is called by the following functions:
    - `event_notifier_error_accounting_register_app` (lttng-tools)
    - `duplicate_stream_object` (lttng-tools)
    - `duplicate_channel_object` (lttng-tools)
  - `lttng_ust_ctl_duplicate_ust_object_data` function returns positive value (= errno = 24 = EMFILE) when system call `dup` returns error
  - However, `duplicate_stream_object` and `duplicate_channel_object` functions expect negative value as error code
  - As a result, these functions cannot handle error and segmentation fault occurs when using `stream->handle`

[Proposal]
  - Currently, `lttng_ust_ctl_duplicate_ust_object_data` function returns either positive or negative value when error happens
  - It looks convention is using negative value for error code (e.g. `-ENOMEM` )
  - So, I propose to change `errno` to `-errno`

Signed-off-by: takeshi.iwanari <takeshi.iwanari@tier4.jp>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: Iccb01930413ecd5a8c58ad267e9c4eca53694dc7

master 2022-06-27 14:34:16 UTC
Fix: Use negative value for error code of lttng_ust_ctl_duplicate_ust_object_...

Author: takeshi.iwanari
Author Date: 2022-06-24 13:17:39 UTC

Fix: Use negative value for error code of lttng_ust_ctl_duplicate_ust_object_data

[As is]
  - `lttng_ust_ctl_duplicate_ust_object_data` function is called by the following functions:
    - `event_notifier_error_accounting_register_app` (lttng-tools)
    - `duplicate_stream_object` (lttng-tools)
    - `duplicate_channel_object` (lttng-tools)
  - `lttng_ust_ctl_duplicate_ust_object_data` function returns positive value (= errno = 24 = EMFILE) when system call `dup` returns error
  - However, `duplicate_stream_object` and `duplicate_channel_object` functions expect negative value as error code
  - As a result, these functions cannot handle error and segmentation fault occurs when using `stream->handle`

[Proposal]
  - Currently, `lttng_ust_ctl_duplicate_ust_object_data` function returns either positive or negative value when error happens
  - It looks convention is using negative value for error code (e.g. `-ENOMEM` )
  - So, I propose to change `errno` to `-errno`

Signed-off-by: takeshi.iwanari <takeshi.iwanari@tier4.jp>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: Iccb01930413ecd5a8c58ad267e9c4eca53694dc7

stable-2.11 2022-01-05 21:15:00 UTC
Version 2.11.5

Author: Mathieu Desnoyers
Author Date: 2022-01-05 21:15:00 UTC

Version 2.11.5

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Change-Id: I66c9383cdfb1d279a25bf428c75fb031d7a44c32

stable-2.10 2020-03-04 21:05:06 UTC
Version 2.10.7

Author: Mathieu Desnoyers
Author Date: 2020-03-04 21:05:06 UTC

Version 2.10.7

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

stable-2.9 2019-10-17 19:26:22 UTC
Version 2.9.7

Author: Mathieu Desnoyers
Author Date: 2019-10-17 19:26:22 UTC

Version 2.9.7

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

stable-2.7 2017-11-06 21:36:32 UTC
ABI: refuse non-matching ABI minor version on event registration

Author: Jonathan Rajotte
Author Date: 2017-11-06 21:10:44 UTC

ABI: refuse non-matching ABI minor version on event registration

In scenarios where a lttng-tools 2.8 (lttng-ust 2.8) stack is running
and an application linked against a lttng-ust 2.7, event registration
will fail on fields size validation [1]. This is not expected based on
the ABI versioning exposed by lttng-ust 2.7 (6.0) and lttng-ust 2.8
(6.1).

The same happen if the scenario is reversed.

This is the result of a change in _ustctl_basic_type.

2.8 introduced enumeration to _ustctl_basic_type. The defined padding is
of 296 while the new union member is 312 (310 of real data + 2 for
alignment) pushing the structure size to 312 instead of the previous
296. This should have been an major ABI break but until now the problem
did not surface.

To prevent this, refuse non matching minor version. No need to check for
particular major,minor version since only 6.0 (ust 2.7) and 6.1 (ust
2.8) exist until a major ABI break.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

stable-2.8 2017-11-06 21:36:17 UTC
ABI: refuse non-matching ABI minor version on event registration

Author: Jonathan Rajotte
Author Date: 2017-11-06 21:10:44 UTC

ABI: refuse non-matching ABI minor version on event registration

In scenarios where a lttng-tools 2.8 (lttng-ust 2.8) stack is running
and an application linked against a lttng-ust 2.7, event registration
will fail on fields size validation [1]. This is not expected based on
the ABI versioning exposed by lttng-ust 2.7 (6.0) and lttng-ust 2.8
(6.1).

The same happen if the scenario is reversed.

This is the result of a change in _ustctl_basic_type.

2.8 introduced enumeration to _ustctl_basic_type. The defined padding is
of 296 while the new union member is 312 (310 of real data + 2 for
alignment) pushing the structure size to 312 instead of the previous
296. This should have been an major ABI break but until now the problem
did not surface.

To prevent this, refuse non matching minor version. No need to check for
particular major,minor version since only 6.0 (ust 2.7) and 6.1 (ust
2.8) exist until a major ABI break.

Signed-off-by: Jonathan Rajotte <jonathan.rajotte-julien@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

stable-2.6 2016-05-20 21:49:06 UTC
Version 2.6.7

Author: Mathieu Desnoyers
Author Date: 2016-05-20 21:49:06 UTC

Version 2.6.7

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

stable-2.5 2015-09-24 20:24:08 UTC
Version 2.5.7

Author: Mathieu Desnoyers
Author Date: 2015-09-24 20:24:08 UTC

Version 2.5.7

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

stable-2.4 2015-01-26 20:21:13 UTC
Version 2.4.4

Author: Mathieu Desnoyers
Author Date: 2015-01-26 20:21:13 UTC

Version 2.4.4

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

stable-2.3 2014-03-10 15:17:25 UTC
Fix: incorrect urcu git URL in README

Author: Mathieu Desnoyers
Author Date: 2014-03-10 15:16:35 UTC

Fix: incorrect urcu git URL in README

Reported-by: Ruslan Uvashev <ruslan.uvashev@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

stable-2.2 2014-02-28 17:08:31 UTC
Version 2.2.3

Author: Mathieu Desnoyers
Author Date: 2014-02-28 17:08:31 UTC

Version 2.2.3

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

stable-2.1 2014-02-05 00:39:28 UTC
Fix: liblttng-ust-fork Makefile flags mismatch

Author: Mathieu Desnoyers
Author Date: 2014-02-05 00:38:19 UTC

Fix: liblttng-ust-fork Makefile flags mismatch

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

stable-2.0 2013-07-11 20:14:39 UTC
Version 2.0.8

Author: Mathieu Desnoyers
Author Date: 2013-07-11 20:14:39 UTC

Version 2.0.8

Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

cygwin-2.0-experimental 2012-12-21 18:38:22 UTC
Add a README.cygwin detailing Cygwin specific build/install instructions

Author: Christian Babeux
Author Date: 2012-12-21 18:38:22 UTC

Add a README.cygwin detailing Cygwin specific build/install instructions

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

ust/callsite 2012-10-23 19:57:55 UTC
Fix: Fix self-assign warning on struct ustfork_clone_info init

Author: Christian Babeux
Author Date: 2012-10-23 19:57:55 UTC

Fix: Fix self-assign warning on struct ustfork_clone_info init

Use the proper field designator syntax (C99) to initialize the
ustfork_clone_info struct.

Signed-off-by: Christian Babeux <christian.babeux@efficios.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>

dev 2012-03-06 23:10:59 UTC
Merge branch 'master' into dev

Author: Mathieu Desnoyers
Author Date: 2012-03-06 23:10:59 UTC

Merge branch 'master' into dev

118 of 18 results

Other repositories

Name Last Modified
lp:lttng-ust 2022-06-27
lp:~lttng/lttng-ust/+git/packaging 2022-02-21
12 of 2 results
You can't create new repositories for LTTng-UST.