LP: #1826323 - Dehydrate nodes with the VMFS layout as having a RESERVED fs.
The UI knows that a partition is in use when it has a mounted partition. VMware
ESXi does not directly mount the partitions used. As MAAS can't model that
inject a place holder so the UI knows that these partitions are in use.
Improve the check for checking whether a database is dirty.
The previous code tried to check, but it's was using an unreliable way,
and it ended up always marking the database as dirty.
Now we assume that the database is dirty, but allow tests to mark it as
clean, if it knows that the transaction was not committed.
MAASServerTestCase was changed to mark the database as clean, resulting
in the databases getting reused often and cuts the test suite run time
in half.
LP: #1825240 - Do not allow datastores to be created unless the VMFS6 storage layout has been applied.
VMFS datastores only work with VMware ESXi. Prevent them from being created
unless the VMFS6 storage layout has been previously applied. This prevents
users from thinking we support VMFS Datastores on other operating systems.
To be backwards compatible with previous versions of MAAS VMware ESXi can
still be deployed without applying the VMFS6 storage layout. In that case
the default layout, including a datastore will be applied on deployment.
If the VMFS6 storage layout is applied make sure a datastore is defined
as one will always be created.
LP: #1821220 - Prevent base ESXi partitions from being modified.
The VMware ESXi image is a DD image which contains a base set of 8 partitions
which may not be modified. This ensures onces the VMFS6 storage layout a
user cannot delete, format, or mount any of those partitions. To remove
them a different layout must be applied first.
VMware ESXi also skips partition 4 in its layout. MAAS was not properly
skipping this partition, this has been fixed.
