Merge ~ltrager/maas:lp1848171 into maas:master

Proposed by Lee Trager
Status: Merged
Approved by: Lee Trager
Approved revision: b6f85b97e0870d89b56c85c26af1a77956b86b7a
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ltrager/maas:lp1848171
Merge into: maas:master
Diff against target: 84 lines (+30/-0)
3 files modified
src/maasserver/websockets/handlers/node.py (+9/-0)
src/maasserver/websockets/handlers/tests/test_device.py (+10/-0)
src/maasserver/websockets/handlers/tests/test_machine.py (+11/-0)
Reviewer Review Type Date Requested Status
Newell Jensen (community) Approve
MAAS Lander Needs Fixing
Review via email: mp+375059@code.launchpad.net

Commit message

LP: #1848171 - Add link_speeds to websocket machine list output.

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b lp1848171 lp:~ltrager/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/6946/console
COMMIT: 48610c2ffa7bd1159ff427d7a9e87ece11749837

review: Needs Fixing
Revision history for this message
Newell Jensen (newell-jensen) wrote :

+1

review: Approve
~ltrager/maas:lp1848171 updated
b6f85b9... by Lee Trager

Fix failing tests

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/src/maasserver/websockets/handlers/node.py b/src/maasserver/websockets/handlers/node.py
index ec688b4..03ce848 100644
--- a/src/maasserver/websockets/handlers/node.py
+++ b/src/maasserver/websockets/handlers/node.py
@@ -265,6 +265,15 @@ class NodeHandler(TimestampedModelHandler):
265 data["extra_macs"] = [265 data["extra_macs"] = [
266 "%s" % mac_address for mac_address in obj.get_extra_macs()266 "%s" % mac_address for mac_address in obj.get_extra_macs()
267 ]267 ]
268 data["link_speeds"] = sorted(
269 set(
270 [
271 interface.link_speed
272 for interface in obj.interface_set.all()
273 if interface.link_speed > 0
274 ]
275 )
276 )
268277
269 if not for_list:278 if not for_list:
270 data["on_network"] = obj.on_network()279 data["on_network"] = obj.on_network()
diff --git a/src/maasserver/websockets/handlers/tests/test_device.py b/src/maasserver/websockets/handlers/tests/test_device.py
index 0668b74..a2dd93a 100644
--- a/src/maasserver/websockets/handlers/tests/test_device.py
+++ b/src/maasserver/websockets/handlers/tests/test_device.py
@@ -141,6 +141,15 @@ class TestDeviceHandler(MAASTransactionServerTestCase):
141 "%s" % mac_address.mac_address141 "%s" % mac_address.mac_address
142 for mac_address in node.get_extra_macs()142 for mac_address in node.get_extra_macs()
143 ],143 ],
144 "link_speeds": sorted(
145 set(
146 [
147 interface.link_speed
148 for interface in node.interface_set.all()
149 if interface.link_speed > 0
150 ]
151 )
152 ),
144 "fqdn": node.fqdn,153 "fqdn": node.fqdn,
145 "hostname": node.hostname,154 "hostname": node.hostname,
146 "description": node.description,155 "description": node.description,
@@ -193,6 +202,7 @@ class TestDeviceHandler(MAASTransactionServerTestCase):
193 "primary_mac",202 "primary_mac",
194 "spaces",203 "spaces",
195 "subnets",204 "subnets",
205 "link_speeds",
196 "tags",206 "tags",
197 "interface_speed",207 "interface_speed",
198 "link_connected",208 "link_connected",
diff --git a/src/maasserver/websockets/handlers/tests/test_machine.py b/src/maasserver/websockets/handlers/tests/test_machine.py
index 120fe3c..7307c56 100644
--- a/src/maasserver/websockets/handlers/tests/test_machine.py
+++ b/src/maasserver/websockets/handlers/tests/test_machine.py
@@ -251,6 +251,15 @@ class TestMachineHandler(MAASServerTestCase):
251 "extra_macs": [251 "extra_macs": [
252 "%s" % mac_address for mac_address in node.get_extra_macs()252 "%s" % mac_address for mac_address in node.get_extra_macs()
253 ],253 ],
254 "link_speeds": sorted(
255 set(
256 [
257 interface.link_speed
258 for interface in node.interface_set.all()
259 if interface.link_speed > 0
260 ]
261 )
262 ),
254 "fqdn": node.fqdn,263 "fqdn": node.fqdn,
255 "hwe_kernel": make_hwe_kernel_ui_text(node.hwe_kernel),264 "hwe_kernel": make_hwe_kernel_ui_text(node.hwe_kernel),
256 "hostname": node.hostname,265 "hostname": node.hostname,
@@ -337,6 +346,7 @@ class TestMachineHandler(MAASServerTestCase):
337 "dhcp_on",346 "dhcp_on",
338 "distro_series",347 "distro_series",
339 "extra_macs",348 "extra_macs",
349 "link_speeds",
340 "fabrics",350 "fabrics",
341 "fqdn",351 "fqdn",
342 "has_logs",352 "has_logs",
@@ -2283,6 +2293,7 @@ class TestMachineHandler(MAASServerTestCase):
2283 self.expectThat(created_node["hostname"], Equals(hostname))2293 self.expectThat(created_node["hostname"], Equals(hostname))
2284 self.expectThat(created_node["pxe_mac"], Equals(mac))2294 self.expectThat(created_node["pxe_mac"], Equals(mac))
2285 self.expectThat(created_node["extra_macs"], Equals([]))2295 self.expectThat(created_node["extra_macs"], Equals([]))
2296 self.expectThat(created_node["link_speeds"], Equals([]))
2286 self.expectThat(created_node["architecture"], Equals(architecture))2297 self.expectThat(created_node["architecture"], Equals(architecture))
2287 self.expectThat(created_node["description"], Equals(description))2298 self.expectThat(created_node["description"], Equals(description))
2288 self.expectThat(created_node["zone"]["id"], Equals(zone.id))2299 self.expectThat(created_node["zone"]["id"], Equals(zone.id))

Subscribers

People subscribed via source and target branches