Merge ~ltrager/maas:lp1848171 into maas:master

Proposed by Lee Trager
Status: Merged
Approved by: Lee Trager
Approved revision: b6f85b97e0870d89b56c85c26af1a77956b86b7a
Merge reported by: MAAS Lander
Merged at revision: not available
Proposed branch: ~ltrager/maas:lp1848171
Merge into: maas:master
Diff against target: 84 lines (+30/-0)
3 files modified
src/maasserver/websockets/handlers/node.py (+9/-0)
src/maasserver/websockets/handlers/tests/test_device.py (+10/-0)
src/maasserver/websockets/handlers/tests/test_machine.py (+11/-0)
Reviewer Review Type Date Requested Status
Newell Jensen (community) Approve
MAAS Lander Needs Fixing
Review via email: mp+375059@code.launchpad.net

Commit message

LP: #1848171 - Add link_speeds to websocket machine list output.

To post a comment you must log in.
Revision history for this message
MAAS Lander (maas-lander) wrote :

UNIT TESTS
-b lp1848171 lp:~ltrager/maas/+git/maas into -b master lp:~maas-committers/maas

STATUS: FAILED
LOG: http://maas-ci-jenkins.internal:8080/job/maas/job/branch-tester/6946/console
COMMIT: 48610c2ffa7bd1159ff427d7a9e87ece11749837

review: Needs Fixing
Revision history for this message
Newell Jensen (newell-jensen) wrote :

+1

review: Approve
~ltrager/maas:lp1848171 updated
b6f85b9... by Lee Trager

Fix failing tests

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/src/maasserver/websockets/handlers/node.py b/src/maasserver/websockets/handlers/node.py
2index ec688b4..03ce848 100644
3--- a/src/maasserver/websockets/handlers/node.py
4+++ b/src/maasserver/websockets/handlers/node.py
5@@ -265,6 +265,15 @@ class NodeHandler(TimestampedModelHandler):
6 data["extra_macs"] = [
7 "%s" % mac_address for mac_address in obj.get_extra_macs()
8 ]
9+ data["link_speeds"] = sorted(
10+ set(
11+ [
12+ interface.link_speed
13+ for interface in obj.interface_set.all()
14+ if interface.link_speed > 0
15+ ]
16+ )
17+ )
18
19 if not for_list:
20 data["on_network"] = obj.on_network()
21diff --git a/src/maasserver/websockets/handlers/tests/test_device.py b/src/maasserver/websockets/handlers/tests/test_device.py
22index 0668b74..a2dd93a 100644
23--- a/src/maasserver/websockets/handlers/tests/test_device.py
24+++ b/src/maasserver/websockets/handlers/tests/test_device.py
25@@ -141,6 +141,15 @@ class TestDeviceHandler(MAASTransactionServerTestCase):
26 "%s" % mac_address.mac_address
27 for mac_address in node.get_extra_macs()
28 ],
29+ "link_speeds": sorted(
30+ set(
31+ [
32+ interface.link_speed
33+ for interface in node.interface_set.all()
34+ if interface.link_speed > 0
35+ ]
36+ )
37+ ),
38 "fqdn": node.fqdn,
39 "hostname": node.hostname,
40 "description": node.description,
41@@ -193,6 +202,7 @@ class TestDeviceHandler(MAASTransactionServerTestCase):
42 "primary_mac",
43 "spaces",
44 "subnets",
45+ "link_speeds",
46 "tags",
47 "interface_speed",
48 "link_connected",
49diff --git a/src/maasserver/websockets/handlers/tests/test_machine.py b/src/maasserver/websockets/handlers/tests/test_machine.py
50index 120fe3c..7307c56 100644
51--- a/src/maasserver/websockets/handlers/tests/test_machine.py
52+++ b/src/maasserver/websockets/handlers/tests/test_machine.py
53@@ -251,6 +251,15 @@ class TestMachineHandler(MAASServerTestCase):
54 "extra_macs": [
55 "%s" % mac_address for mac_address in node.get_extra_macs()
56 ],
57+ "link_speeds": sorted(
58+ set(
59+ [
60+ interface.link_speed
61+ for interface in node.interface_set.all()
62+ if interface.link_speed > 0
63+ ]
64+ )
65+ ),
66 "fqdn": node.fqdn,
67 "hwe_kernel": make_hwe_kernel_ui_text(node.hwe_kernel),
68 "hostname": node.hostname,
69@@ -337,6 +346,7 @@ class TestMachineHandler(MAASServerTestCase):
70 "dhcp_on",
71 "distro_series",
72 "extra_macs",
73+ "link_speeds",
74 "fabrics",
75 "fqdn",
76 "has_logs",
77@@ -2283,6 +2293,7 @@ class TestMachineHandler(MAASServerTestCase):
78 self.expectThat(created_node["hostname"], Equals(hostname))
79 self.expectThat(created_node["pxe_mac"], Equals(mac))
80 self.expectThat(created_node["extra_macs"], Equals([]))
81+ self.expectThat(created_node["link_speeds"], Equals([]))
82 self.expectThat(created_node["architecture"], Equals(architecture))
83 self.expectThat(created_node["description"], Equals(description))
84 self.expectThat(created_node["zone"]["id"], Equals(zone.id))

Subscribers

People subscribed via source and target branches