Merge ~ltrager/maas:lp1702567 into maas:master

[Lee Trager]

LP: #1702567 - Make sure maas_api_helper.py is included python3-django-maas.

[Andres Rodriguez (andreserl)]

This is not the right way to add the file. There are install files that need to ha del this or the setup.py

That said, why is this a problem now and not before? No environment I know of seems affected by this...

review: Needs Fixing

[Lee Trager (ltrager)]

This has been a problem for awhile when using make package-dev. I've fixed it previously by manually adding the sym link between from /usr/lib/python3/dist-packages/metadataserver/user_data/templates/snippets/maas_api_helper.py and /usr/lib/python3/dist-packages/provisioningserver/refresh/maas_api_helper.py. This fix survives reinstalls.

When I went to rebuild my environment last week for Bionic I ran into this issue again and was able to come up with this patch to actually fix it.

[MAAS Lander (maas-lander)]

UNIT TESTS
-b lp1702567 lp:~ltrager/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: 47656e27bb0d95b6c179a3f17deda4c197c07ff8

review: Approve

[Newell Jensen (newell-jensen)]

To add weight to this branch being an issue, I have recently ran into this thinking it was a new bug which I have now marked as a duplicate #1813083

Unmerged commits

47656e2... by Lee Trager on 2018-01-08

LP: #1702567 - Make sure maas_api_helper.py is included python3-django-maas

diff --git a/debian/rules b/debian/rules
index 276e347..43c2ee7 100755
--- a/debian/rules
+++ b/debian/rules
@@ -61,10 +61,11 @@ override_dh_auto_install:
 	install -m 644 $(CURDIR)/debian/maas-dhcp.apparmor \
 	    $(CURDIR)/debian/tmp/etc/apparmor.d/dhcpd.d/maas
 
-	# install python3 twisted plugins
+	# install python3 twisted plugins and make sure maas_api_helper is installed
 	set -ex; for python in $(PYTHON3); do \
 		dh_install twisted/plugins/maasregiond.py usr/lib/$$python/dist-packages/twisted/plugins -pmaas-region-api; \
 		dh_install twisted/plugins/maasrackd.py usr/lib/$$python/dist-packages/twisted/plugins -pmaas-rack-controller; \
+		dh_install src/provisioningserver/refresh/maas_api_helper.py usr/lib/$$python/dist-packages/metadataserver/user_data/templates/snippets -ppython3-django-maas; \
 	done
 
 	dh_install --list-missing