Merge ~ltrager/maas:lp1730976 into maas:master

[Lee Trager]

LP: #1730976 - Only show storage device health status for physical storage devices

[MAAS Lander (maas-lander)]

UNIT TESTS
-b lp1730976 lp:~ltrager/maas into -b master lp:~maas-committers/maas

STATUS: SUCCESS
COMMIT: e063bf53b0a095fcdd7b53a68f4f2c190fb9e880

review: Approve

[Björn Tillenius (bjornt)]

The change itself is probably good for now, but I don't think it makes sense to link bug #1730976 to this branch. That bug talks about displaying the health of the underlying physical device.

Or am I missing something?

review: Needs Information

[Andres Rodriguez (andreserl)]

Had a chat with Maria and this is what she said:
https://bugs.launchpad.net/maas/+bug/1730976/comments/4

So in other words, only physical devices should have hardware testing info.

[Björn Tillenius (bjornt)]

Ok. Could you please update the bug title and description then, so that it's clear?

[Andres Rodriguez (andreserl)]

review: Approve

diff --git a/src/maasserver/static/partials/node-details.html b/src/maasserver/static/partials/node-details.html
index 5d9493b..bafe89a 100755
--- a/src/maasserver/static/partials/node-details.html
+++ b/src/maasserver/static/partials/node-details.html
@@ -2322,11 +2322,13 @@
                                     <div class="table__data table-col--15" aria-label="Device type">{$ getDeviceType(item) $}</div>
                                     <div class="table__data table-col--35" aria-label="Used for">{$ item.used_for $}</div>
                                     <div class="table__data table-col--26" aria-label="Health">
-                                      <span data-maas-script-status="script-status" data-script-status="item.test_status" data-ng-if="item.type === 'physical'"></span>
-                                      <span data-ng-if="item.test_status === 0 || item.test_status === 1 || item.test_status === 2 || item.test_status === 5 || item.test_status === 7">Ok</span>
-                                      <span data-ng-if="item.test_status === 3 || item.test_status === 4 || item.test_status === 8">Error</span>
-                                      <span data-ng-if="item.test_status === 6">Degraded</span>
-                                      <span data-ng-if="item.test_status === -1">Unknown</span>
+                                        <span data-ng-if="item.type === 'physical'">
+                                            <span data-maas-script-status="script-status" data-script-status="item.test_status"></span>
+                                            <span data-ng-if="item.test_status === 0 || item.test_status === 1 || item.test_status === 2 || item.test_status === 5 || item.test_status === 7">Ok</span>
+                                            <span data-ng-if="item.test_status === 3 || item.test_status === 4 || item.test_status === 8">Error</span>
+                                            <span data-ng-if="item.test_status === 6">Degraded</span>
+                                            <span data-ng-if="item.test_status === -1">Unknown</span>
+                                        </span>
                                     </div>
                                 </div>
                             </div>