Code review comment for lp:~ltrager/maas-images/fix_building_bootloaders
Revision history for this message
| Scott Moser (smoser) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
As long as gpgv takes multiple --keyring arguments as you imply here the change looks fine.
Just some comments about readability. I've just learned to do subprocess code like this over time to (possibly) avoid having to type 'man some-command' in order to figure out:
some-command -acf foo --flag1 --flag2 foo2 bar
Just better to do:
some-command --activate --configure --file=foo --flag1 --flag2=foo2 bar