Merge lp:~ltrager/maas-images/fix_building_bootloaders into lp:maas-images
Proposed by
Lee Trager
Status: | Merged |
---|---|
Merged at revision: | 409 |
Proposed branch: | lp:~ltrager/maas-images/fix_building_bootloaders |
Merge into: | lp:maas-images |
Diff against target: |
27 lines (+8/-2) 1 file modified
meph2/commands/dpkg.py (+8/-2) |
To merge this branch: | bzr merge lp:~ltrager/maas-images/fix_building_bootloaders |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
maintainers of maas images | Pending | ||
Review via email: mp+354064@code.launchpad.net |
Commit message
Fix building bootloaders.
This fixes bootloaders failing to build due to being unable to verify the
deb file GPG key and works around LP:1790003 by specifying a prefix when
using grub-mkimage.
To post a comment you must log in.
As long as gpgv takes multiple --keyring arguments as you imply here the change looks fine.
Just some comments about readability. I've just learned to do subprocess code like this over time to (possibly) avoid having to type 'man some-command' in order to figure out:
some-command -acf foo --flag1 --flag2 foo2 bar
Just better to do:
some-command --activate --configure --file=foo --flag1 --flag2=foo2 bar