Merge lp:~ltrager/maas-images/bootloaders_proposed into lp:maas-images

Proposed by Lee Trager
Status: Merged
Merged at revision: 394
Proposed branch: lp:~ltrager/maas-images/bootloaders_proposed
Merge into: lp:maas-images
Diff against target: 76 lines (+17/-7)
2 files modified
meph2/commands/dpkg.py (+10/-4)
meph2/commands/mimport.py (+7/-3)
To merge this branch: bzr merge lp:~ltrager/maas-images/bootloaders_proposed
Reviewer Review Type Date Requested Status
Andres Rodriguez (community) Approve
Scott Moser Pending
Review via email: mp+342893@code.launchpad.net

Commit message

Add --proposed to import command for bootloaders.

Description of the change

Output of meph2-import --proposed bootloaders.yaml bootloaders-proposed

http://162.213.35.187/bootloaders-proposed/

To post a comment you must log in.
Revision history for this message
Andres Rodriguez (andreserl) wrote :

lgtm!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'meph2/commands/dpkg.py'
--- meph2/commands/dpkg.py 2016-08-24 20:40:23 +0000
+++ meph2/commands/dpkg.py 2018-04-09 19:55:25 +0000
@@ -102,7 +102,9 @@
102 return ret == 0102 return ret == 0
103103
104104
105def get_package(archive, pkg_name, architecture, release=None, dest=None):105def get_package(
106 archive, pkg_name, architecture, release=None, dest=None,
107 proposed=False):
106 """Look through the archives for package metadata. If a dest is given108 """Look through the archives for package metadata. If a dest is given
107 download the package.109 download the package.
108110
@@ -112,7 +114,10 @@
112 release = get_distro_release() if release is None else release114 release = get_distro_release() if release is None else release
113 package = None115 package = None
114 # Find the latest version of the package116 # Find the latest version of the package
115 for dist in ('%s-updates' % release, '%s-security' % release, release):117 dists = ('%s-updates' % release, '%s-security' % release, release)
118 if proposed:
119 dists = ('%s-proposed' % release,) + dists
120 for dist in dists:
116 base_url = '%s/dists/%s' % (archive, dist)121 base_url = '%s/dists/%s' % (archive, dist)
117 packages = get_packages(base_url, architecture, pkg_name)122 packages = get_packages(base_url, architecture, pkg_name)
118 if pkg_name in packages:123 if pkg_name in packages:
@@ -218,11 +223,12 @@
218223
219def extract_files_from_packages(224def extract_files_from_packages(
220 archive, packages, architecture, files, release, target, path,225 archive, packages, architecture, files, release, target, path,
221 grub_format=None, grub_config=None, grub_output=None):226 grub_format=None, grub_config=None, grub_output=None, proposed=False):
222 tmp = tempfile.mkdtemp(prefix='maas-images-')227 tmp = tempfile.mkdtemp(prefix='maas-images-')
223 src_packages = []228 src_packages = []
224 for package in packages:229 for package in packages:
225 package = get_package(archive, package, architecture, release, tmp)230 package = get_package(
231 archive, package, architecture, release, tmp, proposed=proposed)
226 pkg_path = os.path.join(tmp, os.path.basename(package['Filename']))232 pkg_path = os.path.join(tmp, os.path.basename(package['Filename']))
227 if pkg_path is None:233 if pkg_path is None:
228 sys.stderr.write('%s not found in archives!' % package)234 sys.stderr.write('%s not found in archives!' % package)
229235
=== modified file 'meph2/commands/mimport.py'
--- meph2/commands/mimport.py 2017-05-02 07:31:59 +0000
+++ meph2/commands/mimport.py 2018-04-09 19:55:25 +0000
@@ -97,8 +97,9 @@
97 src_packages = {}97 src_packages = {}
98 for package in firmware_platform['packages']:98 for package in firmware_platform['packages']:
99 package_info = get_package(99 package_info = get_package(
100 firmware_platform['archive'], package,100 archive=firmware_platform['archive'], pkg_name=package,
101 firmware_platform['arch'], firmware_platform['release'])101 architecture=firmware_platform['arch'],
102 release=firmware_platform['release'], proposed=args.proposed)
102 # Some source packages include the package version in the source103 # Some source packages include the package version in the source
103 # name. Only take the name, not the version.104 # name. Only take the name, not the version.
104 src_package_name = package_info['Source'].split(' ')[0]105 src_package_name = package_info['Source'].split(' ')[0]
@@ -167,7 +168,7 @@
167 firmware_platform['arch'], firmware_platform['files'],168 firmware_platform['arch'], firmware_platform['files'],
168 firmware_platform['release'], args.target, path, grub_format,169 firmware_platform['release'], args.target, path, grub_format,
169 firmware_platform.get('grub_config'),170 firmware_platform.get('grub_config'),
170 firmware_platform.get('grub_output'))171 firmware_platform.get('grub_output'), args.proposed)
171 product_tree['products'][product_id]['versions'][version] = {172 product_tree['products'][product_id]['versions'][version] = {
172 'items': items173 'items': items
173 }174 }
@@ -308,6 +309,9 @@
308 args = [args]309 args = [args]
309 parser.add_argument(*args, **kwargs)310 parser.add_argument(*args, **kwargs)
310 parser.set_defaults(action=main_import)311 parser.set_defaults(action=main_import)
312 parser.add_argument(
313 '--proposed', help='Pull bootloaders from proposed',
314 action='store_true', default=False)
311315
312 args = parser.parse_args()316 args = parser.parse_args()
313 if not getattr(args, 'action', None):317 if not getattr(args, 'action', None):

Subscribers

People subscribed via source and target branches