Code review comment for ~logrotate-charmers/charm-logrotated:bugs_1833095_1833093

Revision history for this message
Paul Goins (vultaire) wrote :

Looks pretty good. I've suggested a few small improvements, although functionally the code is fine as-is without them. However, removal of the copyright blocks concerns me - I think those need to be restored.

review: Needs Fixing

« Back to merge proposal