~logrotate-charmers/charm-logrotated:bugs_1833095_1833093

Branch merges

Propose for merging

Merged into charm-logrotated:master at revision b2e03efd1888e6644d178af2f5f098ee326e9df5

Paul Goins: Approve on 2020-02-25

Canonical IS Reviewers: Pending requested 2020-01-31

Diff: 674 lines (+151/-132)

10 files modified

actions/actions.py (+12/-21)
dev/null (+0/-13)
lib/lib_cron.py (+38/-32)
lib/lib_logrotate.py (+20/-25)
reactive/logrotate.py (+20/-8)
tests/functional/conftest.py (+14/-9)
tests/functional/juju_tools.py (+14/-13)
tests/functional/test_logrotate.py (+5/-2)
tests/unit/conftest.py (+11/-0)
tests/unit/test_logrotate.py (+17/-9)

api

Merged into ~logrotate-charmers/charm-logrotated:master at revision 6d391ef597fad5552bfdee132025c4aa603a21d9

Diko Parvanov: Approve on 2019-06-19

Diff: 672 lines (+148/-131)

10 files modified

actions/actions.py (+12/-21)
dev/null (+0/-13)
lib/lib_cron.py (+38/-32)
lib/lib_logrotate.py (+17/-24)
reactive/logrotate.py (+20/-8)
tests/functional/conftest.py (+14/-9)
tests/functional/juju_tools.py (+14/-13)
tests/functional/test_logrotate.py (+5/-2)
tests/unit/conftest.py (+11/-0)
tests/unit/test_logrotate.py (+17/-9)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

6d391ef... by Diko Parvanov on 2019-06-19

Fixed linting and unit testing

Fixed the linting to pass the tox -e lint test.
Fixed the unit testing to pass tox -e unit,
regression from previous commits.

Closes-Bug: 1833095
Closes-Bug: 1833093

8851293... by Diko Parvanov on 2019-06-14

Fixed a bug with default retention count

count variable did not have a default value
now falls back to lowest interval - days

fd4486c... by Diko Parvanov on 2019-06-14

Fixed indentation in lib_logrotate

77e4d7f... by Diko Parvanov on 2019-06-14

Fixed a bug in lib_logrotate

5b87d0c... by Diko Parvanov on 2019-06-13

Added Juju header check

When modifying the files the charm now adds headers
to inform the user that the files are maintained
by Juju and manual changes might be overwritten.

e0d47ec... by Diko Parvanov on 2019-06-13

Changed default config

Set default retention from 180 to 30 days.

6c25d17... by Diko Parvanov on 2019-06-10

Changed logrotate-cronjob-frequency to string

As proposed on LP#1832208 changed the option
from int to string

Closes-Bug: 1832208

94ca0c2... by David O Neill on 2019-06-05

Updates for cron and charm actions

Added cronjob functionality to update logrotate files
Added actions to force updating of cron/logrotate files
Decoupled from reactive framework to allow running in cronjob

da8a3c0... by Diko Parvanov on 2019-05-13

Fixed multiple typos

955fdf0... by Diko Parvanov on 2019-05-13

Fixed artifacts from previous merge