Merge ~lkundrak/kicad/+git/kicad:appstream-data into ~kicad-product-committers/kicad:master

Proposed by Lubomir Rintel
Status: Merged
Approved by: Wayne Stambaugh
Approved revision: fd62891fb3da986af5d755904a5c441a57f5beaa
Merge reported by: Wayne Stambaugh
Merged at revision: not available
Proposed branch: ~lkundrak/kicad/+git/kicad:appstream-data
Merge into: ~kicad-product-committers/kicad:master
Diff against target: 81 lines (+57/-0)
2 files modified
CMakeLists.txt (+7/-0)
resources/linux/appdata/kicad.appdata.xml (+50/-0)
Reviewer Review Type Date Requested Status
Chris Pavlina Pending
Review via email: mp+323027@code.launchpad.net

Description of the change

Following up on: https://code.launchpad.net/~lkundrak/kicad/appstream-data/+merge/293391

The screenshots may potentially end up in a somewhat more sensible location:
https://github.com/KiCad/kicad-website/pull/197

To post a comment you must log in.
Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

Have the links to the website images been updated yet so I can get this merged? Should this merge request be linked against this bug report?

https://code.launchpad.net/~lkundrak/kicad/+git/kicad/+merge/323027

I know this bug report was for appdata but isn't appstream the successor to appdata?

Revision history for this message
Lubomir Rintel (lkundrak) wrote :

> Have the links to the website images been updated yet so I can get this
> merged?

Yes.

> Should this merge request be linked against this bug report?
>
> https://code.launchpad.net/~lkundrak/kicad/+git/kicad/+merge/323027

Not sure what that means.

> I know this bug report was for appdata but isn't appstream the successor to
> appdata?

AppData is part of the AppStream specification. It's the XML files with the application metadata.

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

On 4/27/2017 6:29 AM, Lubomir Rintel wrote:
>> Have the links to the website images been updated yet so I can get this
>> merged?
>
> Yes.

I'll try to get this merged over the weekend. I haven't attempted to
merge git repos using launchpad so that could be interesting.

>
>> Should this merge request be linked against this bug report?
>>
>> https://code.launchpad.net/~lkundrak/kicad/+git/kicad/+merge/323027
>
> Not sure what that means.

Launchpad merge requests can be linked against bug reports so when the
merge request is accepted, the bug report can be tagged as fix
committed. Your answer below means that this bug report should be
linked against your merge request.

>
>> I know this bug report was for appdata but isn't appstream the successor to
>> appdata?
>
> AppData is part of the AppStream specification. It's the XML files with the application metadata.
>

Revision history for this message
Wayne Stambaugh (stambaughw) wrote :

I merged your patch into the master branch. Thank you for your contribution to KiCad.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/CMakeLists.txt b/CMakeLists.txt
2index 9fec4a2..5822c44 100644
3--- a/CMakeLists.txt
4+++ b/CMakeLists.txt
5@@ -795,6 +795,7 @@ if( UNIX AND NOT APPLE )
6 set( UNIX_MIME_FILES ${UNIX_MIME_DIR}/mime )
7 set( UNIX_ICON_FILES ${UNIX_MIME_DIR}/icons )
8 set( UNIX_APPLICATIONS_FILES ${UNIX_MIME_DIR}/applications )
9+ set( UNIX_APPDATA_FILES resources/linux/appdata )
10
11 # Install Mime directory
12 install( DIRECTORY ${UNIX_ICON_FILES}
13@@ -813,6 +814,12 @@ if( UNIX AND NOT APPLE )
14 DESTINATION ${CMAKE_INSTALL_PREFIX}/share
15 COMPONENT resources
16 )
17+
18+ # Install AppStream directory (app store entry)
19+ install( DIRECTORY ${UNIX_APPDATA_FILES}
20+ DESTINATION ${CMAKE_INSTALL_PREFIX}/share
21+ COMPONENT resources
22+ )
23 endif()
24
25 #include( CTest )
26diff --git a/resources/linux/appdata/kicad.appdata.xml b/resources/linux/appdata/kicad.appdata.xml
27new file mode 100644
28index 0000000..8f78863
29--- /dev/null
30+++ b/resources/linux/appdata/kicad.appdata.xml
31@@ -0,0 +1,50 @@
32+<?xml version="1.0" encoding="UTF-8"?>
33+<!-- Copyright (C) 2016-2017 Lubomir Rintel <lkundrak@v3.sk> -->
34+<!-- Copyright (C) 2016-2017 KiCad Developers, see AUTHORS.txt for contributors. -->
35+<component type="desktop">
36+ <id>kicad.desktop</id>
37+ <name>KiCad</name>
38+ <project_license>GPL-2.0+</project_license>
39+ <metadata_license>CC0-1.0</metadata_license>
40+ <summary>EDA Suite</summary>
41+
42+ <keywords>
43+ <keyword>KiCad</keyword>
44+ <keyword>EDA</keyword>
45+ <keyword>PCB</keyword>
46+ <keyword>Schema</keyword>
47+ <keyword>PcbNew</keyword>
48+ <keyword>Eeschema</keyword>
49+ </keywords>
50+
51+ <description>
52+ <p>A Cross Platform and Open Source Electronics Design Automation Suite.</p>
53+ <p>The programs handle Schematic Capture, and PCB Layout with Gerber output.</p>
54+ </description>
55+
56+ <screenshots>
57+ <screenshot type="default">
58+ <image width="1024" height="576">http://kicad-pcb.org/img/screenshots/appstream/kicad.png</image>
59+ </screenshot>
60+
61+ <screenshot>
62+ <caption>Eeschema Schematic Editor</caption>
63+ <image width="1024" height="576">http://kicad-pcb.org/img/screenshots/appstream/eeschema.png</image>
64+ </screenshot>
65+
66+ <screenshot>
67+ <caption>PcbNew PCB Layout</caption>
68+ <image width="1024" height="576">http://kicad-pcb.org/img/screenshots/appstream/pcbnew.png</image>
69+ </screenshot>
70+
71+ <screenshot>
72+ <caption>PcbNew 3D Viewer</caption>
73+ <image width="1024" height="576">http://kicad-pcb.org/img/screenshots/appstream/3dviewer.png</image>
74+ </screenshot>
75+ </screenshots>
76+
77+ <url type="homepage">http://kicad-pcb.org/</url>
78+ <url type="bugtracker">http://kicad-pcb.org/help/report-a-bug/</url>
79+ <update_contact>kicad-developers@lists.launchpad.net</update_contact>
80+ <developer_name>The KiCad Developers</developer_name>
81+</component>

Subscribers

People subscribed via source and target branches

to status/vote changes: