Merge lp:~liuyq0307/linaro-android-build-tools/monkeyrunner into lp:linaro-android-build-tools

Proposed by Yongqin Liu
Status: Superseded
Proposed branch: lp:~liuyq0307/linaro-android-build-tools/monkeyrunner
Merge into: lp:linaro-android-build-tools
Diff against target: 33 lines (+21/-0)
1 file modified
build-scripts/post-build-lava.py (+21/-0)
To merge this branch: bzr merge lp:~liuyq0307/linaro-android-build-tools/monkeyrunner
Reviewer Review Type Date Requested Status
Paul Sokolovsky Needs Fixing
Review via email: mp+107200@code.launchpad.net

This proposal has been superseded by a proposal from 2012-05-25.

Description of the change

add support for integrating monkeyrunner test from android-build page.

To post a comment you must log in.
Revision history for this message
Yongqin Liu (liuyq0307) wrote :
Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

2 issues:

"##because these action cause android reboot easily" comment is not very clear - to what exactly it relates? Can you either elaborate it (something like "Warning - monkeyrunner actions can cause unexpected Android reboots") or perhaps just remove, because that's probably related more to specific monkeyrunner actions, than to post-build-lava.py's implementation of m-r support.

Also, at lines 18, 19 there's inconsistent indentation/braces placement, it would be nice to have it consistent and match what is used elsewhere in the script.

Thanks.

review: Needs Fixing
433. By Yongqin Liu

update according to the review comment

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'build-scripts/post-build-lava.py'
--- build-scripts/post-build-lava.py 2012-05-17 17:59:51 +0000
+++ build-scripts/post-build-lava.py 2012-05-25 05:36:17 +0000
@@ -118,10 +118,31 @@
118 return test_actions118 return test_actions
119119
120120
121def gen_monkeyrunner_actions():
122 test_actions = []
123 prefix = 'MONKEY_RUNNER_URL_'
124 test_list = []
125 for var in os.environ.keys():
126 if var.startswith(prefix):
127 test_list.append(var)
128 test_list.sort()
129 for var in test_list:
130 url = os.environ.get(var)
131 action = {
132 "command": "lava_android_test_run_monkeyrunner",
133 "parameters":
134 {
135 "url": url
136 }
137 }
138 test_actions.append(action)
139
140
121def gen_test_actions():141def gen_test_actions():
122 test_actions = []142 test_actions = []
123 test_actions.extend(gen_custom_actions())143 test_actions.extend(gen_custom_actions())
124 test_actions.extend(gen_test_plan_actions())144 test_actions.extend(gen_test_plan_actions())
145 test_actions.extend(gen_monkeyrunner_actions())
125 return test_actions146 return test_actions
126147
127148

Subscribers

People subscribed via source and target branches