Code review comment for lp:~liuyq0307/linaro-android-build-tools/monkeyrunner

Revision history for this message
Paul Sokolovsky (pfalcon) wrote :

2 issues:

"##because these action cause android reboot easily" comment is not very clear - to what exactly it relates? Can you either elaborate it (something like "Warning - monkeyrunner actions can cause unexpected Android reboots") or perhaps just remove, because that's probably related more to specific monkeyrunner actions, than to post-build-lava.py's implementation of m-r support.

Also, at lines 18, 19 there's inconsistent indentation/braces placement, it would be nice to have it consistent and match what is used elsewhere in the script.

Thanks.

review: Needs Fixing

« Back to merge proposal