Merge lp:~liuyq0307/lava-dashboard-tool/fix-887963 into lp:lava-dashboard-tool

[Yongqin Liu]

normalize the default output name when not specified.
but because not very clear about the name used to be,
so if the normalize policy has problem, please point out.
And there is the possibility that the name or the location path is too long, but here ignore this case.

[Zygmunt Krynicki (zyga)]

This is still somewhat tricky, could you please change it to default to the SHA of the bundle instead? That is safe and unambiguous.

Thanks for fixing this :)

review: Needs Fixing

[Yongqin Liu (liuyq0307)]

> This is still somewhat tricky, could you please change it to default to the
> SHA of the bundle instead? That is safe and unambiguous.
Right, that's good.

[lp:~liuyq0307/lava-dashboard-tool/fix-887963]

156. By Yongqin Liu on 2011-11-09

modify to use SHA according to the review comment

Unmerged revisions

=== modified file 'lava_dashboard_tool/commands.py'
--- lava_dashboard_tool/commands.py	2011-07-21 16:44:24 +0000
+++ lava_dashboard_tool/commands.py	2011-11-09 12:29:22 +0000
@@ -508,7 +508,7 @@
     def invoke_remote(self):
         response = self.server.get(self.args.SHA1)
         if self.args.output is None:
-            filename = response['content_filename']
+            filename = self.args.SHA1
             if os.path.exists(filename) and not self.args.overwrite:
                 print >> sys.stderr, "File {filename!r} already exists".format(
                         filename=filename)