Merge lp:~liuyq0307/lava-dashboard-tool/fix-887963 into lp:lava-dashboard-tool

Proposed by Yongqin Liu
Status: Merged
Merged at revision: 155
Proposed branch: lp:~liuyq0307/lava-dashboard-tool/fix-887963
Merge into: lp:lava-dashboard-tool
Diff against target: 12 lines (+1/-1)
1 file modified
lava_dashboard_tool/commands.py (+1/-1)
To merge this branch: bzr merge lp:~liuyq0307/lava-dashboard-tool/fix-887963
Reviewer Review Type Date Requested Status
Yongqin Liu self review Approve
Zygmunt Krynicki Pending
Review via email: mp+81727@code.launchpad.net

This proposal supersedes a proposal from 2011-11-09.

Description of the change

normalize the default output name when not specified.
but because not very clear about the name used to be,
so if the normalize policy has problem, please point out.
And there is the possibility that the name or the location path is too long, but here ignore this case.

modify to use SHA as default file name according to the review comment

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote : Posted in a previous version of this proposal

This is still somewhat tricky, could you please change it to default to the SHA of the bundle instead? That is safe and unambiguous.

Thanks for fixing this :)

review: Needs Fixing
Revision history for this message
Yongqin Liu (liuyq0307) wrote : Posted in a previous version of this proposal

> This is still somewhat tricky, could you please change it to default to the
> SHA of the bundle instead? That is safe and unambiguous.
Right, that's good.

Revision history for this message
Yongqin Liu (liuyq0307) :
review: Approve (self review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lava_dashboard_tool/commands.py'
2--- lava_dashboard_tool/commands.py 2011-07-21 16:44:24 +0000
3+++ lava_dashboard_tool/commands.py 2011-11-09 12:23:06 +0000
4@@ -508,7 +508,7 @@
5 def invoke_remote(self):
6 response = self.server.get(self.args.SHA1)
7 if self.args.output is None:
8- filename = response['content_filename']
9+ filename = self.args.SHA1
10 if os.path.exists(filename) and not self.args.overwrite:
11 print >> sys.stderr, "File {filename!r} already exists".format(
12 filename=filename)

Subscribers

People subscribed via source and target branches