Merge lp:~liuyq0307/lava-dashboard-tool/fix-887963 into lp:lava-dashboard-tool
Proposed by
Yongqin Liu
Status: | Merged |
---|---|
Merged at revision: | 155 |
Proposed branch: | lp:~liuyq0307/lava-dashboard-tool/fix-887963 |
Merge into: | lp:lava-dashboard-tool |
Diff against target: |
12 lines (+1/-1) 1 file modified
lava_dashboard_tool/commands.py (+1/-1) |
To merge this branch: | bzr merge lp:~liuyq0307/lava-dashboard-tool/fix-887963 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Yongqin Liu | self review | Approve | |
Zygmunt Krynicki | Pending | ||
Review via email: mp+81727@code.launchpad.net |
This proposal supersedes a proposal from 2011-11-09.
Description of the change
normalize the default output name when not specified.
but because not very clear about the name used to be,
so if the normalize policy has problem, please point out.
And there is the possibility that the name or the location path is too long, but here ignore this case.
modify to use SHA as default file name according to the review comment
To post a comment you must log in.
This is still somewhat tricky, could you please change it to default to the SHA of the bundle instead? That is safe and unambiguous.
Thanks for fixing this :)