Merge ~liushuyu-011/review-tools:master into review-tools:master

Proposed by Zixing Liu
Status: Merged
Merged at revision: 4a80c87cc72d2d41e8e7115679fc258dc7e1a95a
Proposed branch: ~liushuyu-011/review-tools:master
Merge into: review-tools:master
Diff against target: 71 lines (+25/-0)
1 file modified
reviewtools/overrides.py (+25/-0)
Reviewer Review Type Date Requested Status
Emilia Torino Approve
Review via email: mp+460533@code.launchpad.net

Description of the change

This merge proposal adds the contact information of the entire Canonical toolchains squad (a sub-team of Canonical Foundations), as they will be responsible for some of the toolchain-related public Snaps on the Snap Store.

This merge proposal also adds the responsibility override for rustup Snap.

To post a comment you must log in.
Revision history for this message
Emilia Torino (emitorino) wrote :

Very small comment, otherwise LGTM, thanks!

review: Needs Fixing
Revision history for this message
Zixing Liu (liushuyu-011) wrote :

> Very small comment, otherwise LGTM, thanks!

Addressed now.

Revision history for this message
Emilia Torino (emitorino) wrote :

LGTM now, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/reviewtools/overrides.py b/reviewtools/overrides.py
index b06bd17..9d531ef 100644
--- a/reviewtools/overrides.py
+++ b/reviewtools/overrides.py
@@ -1104,6 +1104,12 @@ canonical_desktop = [
1104 "sebastien.bacher@canonical.com",1104 "sebastien.bacher@canonical.com",
1105]1105]
11061106
1107canonical_dotnet = [
1108 "dominik.viererbe@canonical.com",
1109 "mateus.morais@canonical.com",
1110 "samir.kamerkar@canonical.com",
1111]
1112
1107canonical_edgex = [1113canonical_edgex = [
1108 "tony.espy@canonical.com",1114 "tony.espy@canonical.com",
1109 "farshid.tavakolizadeh@canonical.com",1115 "farshid.tavakolizadeh@canonical.com",
@@ -1141,6 +1147,12 @@ canonical_kernel = [
1141 "jesse.sung@canonical.com",1147 "jesse.sung@canonical.com",
1142]1148]
11431149
1150canonical_java = [
1151 "pushkar.kulkarni@canonical.com",
1152 "vladimir.petko@canonical.com",
1153 "samir.kamerkar@canonical.com",
1154]
1155
1144canonical_juju = ["ian.booth@canonical.com", "john.meinel@canonical.com"]1156canonical_juju = ["ian.booth@canonical.com", "john.meinel@canonical.com"]
11451157
1146canonical_k8s = [1158canonical_k8s = [
@@ -1183,6 +1195,11 @@ canonical_openstack = ["billy.olsen@canonical.com", "james.page@canonical.com"]
11831195
1184canonical_pebble = ["cristovao.cordeiro@canonical.com", "ben.hoyt@canonical.com"]1196canonical_pebble = ["cristovao.cordeiro@canonical.com", "ben.hoyt@canonical.com"]
11851197
1198canonical_python = [
1199 "graham.inggs@canonical.com",
1200 "samir.kamerkar@canonical.com",
1201]
1202
1186canonical_rocks = [1203canonical_rocks = [
1187 "athos.ribeiro@canonical.com",1204 "athos.ribeiro@canonical.com",
1188 "carl.csaposs@canonical.com",1205 "carl.csaposs@canonical.com",
@@ -1195,6 +1212,11 @@ canonical_rocks = [
1195 "ubuntu-docker-images@lists.launchpad.net",1212 "ubuntu-docker-images@lists.launchpad.net",
1196]1213]
11971214
1215canonical_rust = [
1216 "zixing.liu@canonical.com",
1217 "samir.kamerkar@canonical.com",
1218]
1219
1198canonical_security = [1220canonical_security = [
1199 "alex.murray@canonical.com",1221 "alex.murray@canonical.com",
1200 "emilia.torino@canonical.com",1222 "emilia.torino@canonical.com",
@@ -1216,6 +1238,8 @@ canonical_snap_store = [
1216 "wouter.bommel@canonical.com",1238 "wouter.bommel@canonical.com",
1217]1239]
12181240
1241canonical_toolchains = canonical_go + canonical_rust + canonical_dotnet + canonical_java
1242
1219# snaps@canonical.com used to be 'snappy-canonical-storeaccount@canonical.com'1243# snaps@canonical.com used to be 'snappy-canonical-storeaccount@canonical.com'
1220# but it was changed a little while ago1244# but it was changed a little while ago
1221update_publisher_overrides = {1245update_publisher_overrides = {
@@ -1405,6 +1429,7 @@ update_publisher_overrides = {
1405 "quadrapassel": canonical_desktop,1429 "quadrapassel": canonical_desktop,
1406 "review-tools": canonical_security,1430 "review-tools": canonical_security,
1407 "rockcraft": canonical_charmcraft,1431 "rockcraft": canonical_charmcraft,
1432 "rustup": canonical_rust,
1408 "se-test-tools": canonical_enablement,1433 "se-test-tools": canonical_enablement,
1409 "shotwell": canonical_desktop,1434 "shotwell": canonical_desktop,
1410 "simple-scan": canonical_desktop,1435 "simple-scan": canonical_desktop,

Subscribers

People subscribed via source and target branches

to all changes: