review-tools

Merge ~liushuyu-011/review-tools:master into review-tools:master

  1. Git
  2. lp:~liushuyu-011/review-tools
  3. master
  4. Merge into master
Proposed by Zixing Liu
Status: Merged
Merged at revision: 4a80c87cc72d2d41e8e7115679fc258dc7e1a95a
Proposed branch: ~liushuyu-011/review-tools:master
Merge into: review-tools:master
Diff against target: 71 lines (+25/-0)
1 file modified
reviewtools/overrides.py (+25/-0)
Reviewer Review Type Date Requested Status
Emilia Torino Approve
Review via email: mp+460533@code.launchpad.net

Description of the change

This merge proposal adds the contact information of the entire Canonical toolchains squad (a sub-team of Canonical Foundations), as they will be responsible for some of the toolchain-related public Snaps on the Snap Store.

This merge proposal also adds the responsibility override for rustup Snap.

To post a comment you must log in.
Revision history for this message
Emilia Torino (emitorino) wrote :

Very small comment, otherwise LGTM, thanks!

review: Needs Fixing
Revision history for this message
Zixing Liu (liushuyu-011) wrote :

> Very small comment, otherwise LGTM, thanks!

Addressed now.

Revision history for this message
Emilia Torino (emitorino) wrote :

LGTM now, thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/reviewtools/overrides.py b/reviewtools/overrides.py
2index b06bd17..9d531ef 100644
3--- a/reviewtools/overrides.py
4+++ b/reviewtools/overrides.py
5@@ -1104,6 +1104,12 @@ canonical_desktop = [
6 "sebastien.bacher@canonical.com",
7 ]
8
9+canonical_dotnet = [
10+ "dominik.viererbe@canonical.com",
11+ "mateus.morais@canonical.com",
12+ "samir.kamerkar@canonical.com",
13+]
14+
15 canonical_edgex = [
16 "tony.espy@canonical.com",
17 "farshid.tavakolizadeh@canonical.com",
18@@ -1141,6 +1147,12 @@ canonical_kernel = [
19 "jesse.sung@canonical.com",
20 ]
21
22+canonical_java = [
23+ "pushkar.kulkarni@canonical.com",
24+ "vladimir.petko@canonical.com",
25+ "samir.kamerkar@canonical.com",
26+]
27+
28 canonical_juju = ["ian.booth@canonical.com", "john.meinel@canonical.com"]
29
30 canonical_k8s = [
31@@ -1183,6 +1195,11 @@ canonical_openstack = ["billy.olsen@canonical.com", "james.page@canonical.com"]
32
33 canonical_pebble = ["cristovao.cordeiro@canonical.com", "ben.hoyt@canonical.com"]
34
35+canonical_python = [
36+ "graham.inggs@canonical.com",
37+ "samir.kamerkar@canonical.com",
38+]
39+
40 canonical_rocks = [
41 "athos.ribeiro@canonical.com",
42 "carl.csaposs@canonical.com",
43@@ -1195,6 +1212,11 @@ canonical_rocks = [
44 "ubuntu-docker-images@lists.launchpad.net",
45 ]
46
47+canonical_rust = [
48+ "zixing.liu@canonical.com",
49+ "samir.kamerkar@canonical.com",
50+]
51+
52 canonical_security = [
53 "alex.murray@canonical.com",
54 "emilia.torino@canonical.com",
55@@ -1216,6 +1238,8 @@ canonical_snap_store = [
56 "wouter.bommel@canonical.com",
57 ]
58
59+canonical_toolchains = canonical_go + canonical_rust + canonical_dotnet + canonical_java
60+
61 # snaps@canonical.com used to be 'snappy-canonical-storeaccount@canonical.com'
62 # but it was changed a little while ago
63 update_publisher_overrides = {
64@@ -1405,6 +1429,7 @@ update_publisher_overrides = {
65 "quadrapassel": canonical_desktop,
66 "review-tools": canonical_security,
67 "rockcraft": canonical_charmcraft,
68+ "rustup": canonical_rust,
69 "se-test-tools": canonical_enablement,
70 "shotwell": canonical_desktop,
71 "simple-scan": canonical_desktop,

Subscribers

People subscribed via source and target branches

to all changes: