Code review comment for lp:~linaro-landing-team-freescale/linaro-image-tools/mx6qsabrelite

Revision history for this message
Ricardo Salveti (rsalveti) wrote :

> On Tue, Dec 13, 2011 at 7:15 AM, Eric Miao <email address hidden> wrote:
> > Eric Miao has proposed merging lp:~linaro-landing-team-freescale/linaro-
> >  class VexpressConfig(BoardConfig):
> >     uboot_flavor = 'ca9x4_ct_vxp'
> >     uboot_in_boot_part = True
> > @@ -1448,6 +1462,7 @@
> >     'efikasb': EfikasbConfig,
> >     'mx51evk': Mx51evkConfig,
> >     'mx53loco': Mx53LoCoConfig,
> > +    'mx6qsabrelite': Mx6qSabreliteConfig,
>
> Ok, so this might be the only line we would need to add. I'm not sure
> what it should point to since it shouldn't have any effect though.

Seems that this would be needed even for v2, otherwise the --dev argument will be invalid. I remember there was a talk about moving the board name to the hwpack itself, so then we could simply remove the --dev argument from the default usage, is that the plan still?

Otherwise we'd need the new class definition or another hack to just enable it at --dev list.

« Back to merge proposal