Merge lp:~linaro-landing-team-freescale/linaro-image-tools/mx6qsabrelite into lp:linaro-image-tools/11.11

[Eric Miao]

This branch added support for i.MX6Q SabreLite board with the hwpack generated daily by Freescale landing team.

[Mattias Backman (mabac)]

On Tue, Dec 13, 2011 at 7:15 AM, Eric Miao <email address hidden> wrote:
> Eric Miao has proposed merging lp:~linaro-landing-team-freescale/linaro-image-tools/mx6qsabrelite into lp:linaro-image-tools.
>
> Requested reviews:
>  linaro-image-tools maintainers (linaro-image-tools)
>
> For more details, see:
> https://code.launchpad.net/~linaro-landing-team-freescale/linaro-image-tools/mx6qsabrelite/+merge/85433
>
> This branch added support for i.MX6Q SabreLite board with the hwpack generated daily by Freescale landing team.

There should be no need to add this to l-i-t for supporting a new
board. Can you tell me what it is you need that can't be passed by the
hwpack?

> --
> https://code.launchpad.net/~linaro-landing-team-freescale/linaro-image-tools/mx6qsabrelite/+merge/85433
> You are subscribed to branch lp:linaro-image-tools.
>
> === modified file 'linaro_image_tools/media_create/boards.py'
> --- linaro_image_tools/media_create/boards.py   2011-11-23 12:49:03 +0000
> +++ linaro_image_tools/media_create/boards.py   2011-12-13 06:14:31 +0000
> @@ -1223,6 +1223,14 @@
>         make_boot_script(boot_env, boot_script_path)
>
>
> +class Mx6Config(Mx5Config):
> +    kernel_addr = '0x10000000'
> +    dtb_addr = '0x11ff0000'
> +    initrd_addr = '0x12000000'
> +    load_addr = '0x10008000'
> +    kernel_flavors = ['linaro-lt-mx6']
> +
> +
>  class Mx51Config(Mx5Config):
>     kernel_addr = '0x90000000'
>     dtb_addr = '0x91ff0000'
> @@ -1259,6 +1267,12 @@
>     dtb_name = 'mx53-loco.dtb'
>
>
> +class Mx6qSabreliteConfig(Mx6Config):
> +    serial_tty = 'ttymxc1'
> +    uboot_flavor = 'mx6qsabrelite'
> +    dtb_name = 'imx6q-sabrelite.dtb'
> +
> +
>  class VexpressConfig(BoardConfig):
>     uboot_flavor = 'ca9x4_ct_vxp'
>     uboot_in_boot_part = True
> @@ -1448,6 +1462,7 @@
>     'efikasb': EfikasbConfig,
>     'mx51evk': Mx51evkConfig,
>     'mx53loco': Mx53LoCoConfig,
> +    'mx6qsabrelite': Mx6qSabreliteConfig,

Ok, so this might be the only line we would need to add. I'm not sure
what it should point to since it shouldn't have any effect though.

>     'overo': OveroConfig,
>     'smdkv310': SMDKV310Config,
>     'origen': OrigenConfig,
>
>

[Ricardo Salveti (rsalveti)]

> On Tue, Dec 13, 2011 at 7:15 AM, Eric Miao <email address hidden> wrote:
> > Eric Miao has proposed merging lp:~linaro-landing-team-freescale/linaro-
> >  class VexpressConfig(BoardConfig):
> >     uboot_flavor = 'ca9x4_ct_vxp'
> >     uboot_in_boot_part = True
> > @@ -1448,6 +1462,7 @@
> >     'efikasb': EfikasbConfig,
> >     'mx51evk': Mx51evkConfig,
> >     'mx53loco': Mx53LoCoConfig,
> > +    'mx6qsabrelite': Mx6qSabreliteConfig,
>
> Ok, so this might be the only line we would need to add. I'm not sure
> what it should point to since it shouldn't have any effect though.

Seems that this would be needed even for v2, otherwise the --dev argument will be invalid. I remember there was a talk about moving the board name to the hwpack itself, so then we could simply remove the --dev argument from the default usage, is that the plan still?

Otherwise we'd need the new class definition or another hack to just enable it at --dev list.

[Mattias Backman (mabac)]

On Wed, Dec 14, 2011 at 12:45 PM, Ricardo Salveti <email address hidden> wrote:
>> On Tue, Dec 13, 2011 at 7:15 AM, Eric Miao <email address hidden> wrote:
>> > Eric Miao has proposed merging lp:~linaro-landing-team-freescale/linaro-
>> >  class VexpressConfig(BoardConfig):
>> >     uboot_flavor = 'ca9x4_ct_vxp'
>> >     uboot_in_boot_part = True
>> > @@ -1448,6 +1462,7 @@
>> >     'efikasb': EfikasbConfig,
>> >     'mx51evk': Mx51evkConfig,
>> >     'mx53loco': Mx53LoCoConfig,
>> > +    'mx6qsabrelite': Mx6qSabreliteConfig,
>>
>> Ok, so this might be the only line we would need to add. I'm not sure
>> what it should point to since it shouldn't have any effect though.
>
> Seems that this would be needed even for v2, otherwise the --dev argument will be invalid. I remember there was a talk about moving the board name to the hwpack itself, so then we could simply remove the --dev argument from the default usage, is that the plan still?
>
> Otherwise we'd need the new class definition or another hack to just enable it at --dev list.

We need to decide how to handle the --dev option. For now we need to
have the BoardConfig although it should be totally blank so we're not
left with more stuff to maintain in l-m-c. We'll sadly still need it
in l-a-m-c so please move the parameters to a BoardConfig in
android_boards.

> --
> https://code.launchpad.net/~linaro-landing-team-freescale/linaro-image-tools/mx6qsabrelite/+merge/85433
> You are subscribed to branch lp:linaro-image-tools.

[lp:~linaro-landing-team-freescale/linaro-image-tools/mx6qsabrelite]

472. By Eric Miao on 2011-12-14

Add support for Freescale i.MX6Q SabreLite board

[Eric Miao (eric.y.miao)]

I've updated the branch and keep the only line necessary. Board specific bits have been moved to the hwpack project file, which has been updated. Tested and worked.

[Mattias Backman (mabac)]

Nice.

review: Approve

=== modified file 'linaro_image_tools/media_create/boards.py'
--- linaro_image_tools/media_create/boards.py	2011-11-23 12:49:03 +0000
+++ linaro_image_tools/media_create/boards.py	2011-12-14 13:17:24 +0000
@@ -1451,6 +1451,7 @@
     'overo': OveroConfig,
     'smdkv310': SMDKV310Config,
     'origen': OrigenConfig,
+    'mx6qsabrelite': BoardConfig,
     }