Code review comment for lp:~linaro-infrastructure/linaro-ci-dashboard/create_job_jenkins_changes

Revision history for this message
Deepti B. Kalakeri (deeptik) wrote :

> Hey Deepti, thanks for the good work..
> Comments following:
>
> initial_data.json is missing the jenkinsserver record as we talked. It is in
> my branch as well so you can leave it as it is, but someone else trying to run
> the application will be confused.

Yes, I did not wanted to overlap your changes, so did not make it part of the MP.
>
> Also, create job method breaks when the name of the method has 'whitespace' in
> it. It creates job on jenkins, but only with the first string. I guess some
> escaping needs to be done here.

I will fix this.
>
> Basically we can't consider this done until we have a build actually working
> on the jenkins when it is scheduled to run. The following problems and
> possible solutions follow:
> 1. I also get a 'permission denied(public key)' on the job build when it tries
> to 'branch' the code from LP.
I was able to get the jobs started to build once I Clicked on the Build button.
I did not see this error though. How does your input in the loopcreate form looks like?

> I've tried it an putting HOME=/tmp/ bzr branch... worked.

> 2. Also after the code is checked out, the script needs to position itself in
> the directory which is checkout.

Yes, correct, so my form inputs looks like this:
Name: Job_name
branch: linaro-ci-dashboard
precommand: cd linaro-ci-dashboard; make syncdb
command: make test

> i.e. cd branch_dir
> 3. We need to clean up the branch_dir either before the build or after (i
> think it's better before)
We can make it part of the command.
>
> Let's get these few problems resolved then we can take a look at the code
> implementation.

« Back to merge proposal