Merge lp:~linaro-infrastructure/linaro-ci-dashboard/create_job_jenkins_changes into lp:linaro-ci-dashboard
Proposed by
Deepti B. Kalakeri
Status: | Merged |
---|---|
Approved by: | Stevan Radaković |
Approved revision: | 16 |
Merged at revision: | 13 |
Proposed branch: | lp:~linaro-infrastructure/linaro-ci-dashboard/create_job_jenkins_changes |
Merge into: | lp:linaro-ci-dashboard |
Diff against target: |
181 lines (+111/-3) 6 files modified
config_template/sample-job/config.xml (+22/-0) dashboard/frontend/fixtures/initial_data.json (+9/-0) dashboard/frontend/models/loop.py (+2/-1) dashboard/jenkinsserver/models/jenkins_server.py (+48/-2) dashboard/jenkinsserver/tests/test_jenkins_server.py (+27/-0) dashboard/settings.py (+3/-0) |
To merge this branch: | bzr merge lp:~linaro-infrastructure/linaro-ci-dashboard/create_job_jenkins_changes |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Stevan Radaković | Approve | ||
Данило Шеган | Pending | ||
Review via email: mp+115802@code.launchpad.net |
Description of the change
Adding changes to create /delete job on jenkins server
To post a comment you must log in.
Hey Deepti, thanks for the good work..
Comments following:
initial_data.json is missing the jenkinsserver record as we talked. It is in my branch as well so you can leave it as it is, but someone else trying to run the application will be confused.
Also, create job method breaks when the name of the method has 'whitespace' in it. It creates job on jenkins, but only with the first string. I guess some escaping needs to be done here.
Basically we can't consider this done until we have a build actually working on the jenkins when it is scheduled to run. The following problems and possible solutions follow:
1. I also get a 'permission denied(public key)' on the job build when it tries to 'branch' the code from LP.
I've tried it an putting HOME=/tmp/ bzr branch... worked.
2. Also after the code is checked out, the script needs to position itself in the directory which is checkout.
i.e. cd branch_dir
3. We need to clean up the branch_dir either before the build or after (i think it's better before)
Let's get these few problems resolved then we can take a look at the code implementation.