Code review comment for lp:~lin-yu/purchase-wkfl/add_product_supplier_info

Hi Pedro,

Thanks for your reply.

I have changed the view for the original supplier info in product form,
changed "product name" to product, corrected the indent space in XML file.
For the price, there are no price field in this object. Do you mean the
quantity field?

BTW, how can I do a average for field like 'lead time' in group by tree
view?

BR,
On 09/16/2013 09:25 PM, Pedro Manuel Baeza wrote:
> Review: Needs Fixing test
>
> Hi Lin,
>
> This is what I mean: this is the screen in Purchases > Products > Products before installing the module:
>
> http://s975.photobucket.com/user/nickPT/media/before_zps8c7c40ca.png.html
>
> And this is the aspect when you install the module:
>
> http://s975.photobucket.com/user/nickPT/media/after_zps66577973.png.html
>
> You can see that it appears the field called "Product Name", that corresponds to product_id, which has no sense in this screen. You aren't also be able to edit prices per quantities with your new screen. The solution is to inherit the form and define a lower priority, selecting explicitly that form on your menu action. Let me know if I can help you with code.
>
> Another thing: please correct mixed indentations (tabs and spaces) on XML file.
>
> Regards.

--
LIN Yu

LIN Yu
/Project Manager/
--
*Elico Corporation, Shanghai
/OpenERP Premium Certified Training Partner/ *
Cell: + 86 186 1691 1351
Office: + 86 21 6211 8017/27
Skype: llccluf
<email address hidden> <mailto:<email address hidden>>
http://www.elico-corp.com

Elico Corp