Merge lp:~lin-yu/purchase-wkfl/add_product_supplier_info into lp:~purchase-core-editors/purchase-wkfl/7.0

[LIN Yu]

Add Module Product Supplier Info
* Modify Codes to adapt rules
* Add a specific View for Product Supplier

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Dear Lin,

Thanks for the contribs, a few remarks:

 * Line 139: no need to instantiate the class anymore, you can remove it
 * Line 110: from openerp.osv import orm, fields then use on line 115 orm.Model
 * Line 136/137: Cust the line to 80 CHAR (pep8)
 * Line 124 to 131: You should better browse all records at once by using, and do not forget context=context:

for id in ids:
   res[id] = {}.fromkeys(field_names, 0.0)
   supplier_info = self.browse(cr, uid, id)

Better:

for record in self.browse(cr, ui, ids, context=context)

Thank you,

Regards,

Joël

review: Needs Fixing (code review, no tests)

[LIN Yu (lin-yu)]

Dear Joël,

Thanks for your reply.
I have modified the code, resubmit the proposal.

BR,
> Dear Lin,
>
> Thanks for the contribs, a few remarks:
>
> * Line 139: no need to instantiate the class anymore, you can remove it
> * Line 110: from openerp.osv import orm, fields then use on line 115
> orm.Model
> * Line 136/137: Cust the line to 80 CHAR (pep8)
> * Line 124 to 131: You should better browse all records at once by using, and
> do not forget context=context:
>
> for id in ids:
> res[id] = {}.fromkeys(field_names, 0.0)
> supplier_info = self.browse(cr, uid, id)
>
> Better:
>
> for record in self.browse(cr, ui, ids, context=context)
>
> Thank you,
>
> Regards,
>
> Joël

review: Needs Resubmitting

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Dear Lyn,

Thanks you for the corrections ! A little tips about Launchpad, you should not make a "Resubmit" yourself, because now, you're a reviewer of your own MP. Nothing important, just to let you know. Better in that case, just commit the changes, push and make a simple comment in the thread about it, like : It's corrected :)

The code looks fine to me now, it would be very much appreciated to have the infos of the index.html in the description of the __openerp__.py file => lots of people look at it to know more on a module, can you add that to it :

"""
This module categorizes each product item by supplier.It allows for users to be able to view a compiled list of products supplied by the supplier. Users can also directly add new products to the supplier's list.
"""

Thanks a lot, this little module looks very useful to me !

Regards,

Joël

review: Needs Fixing (code review, no tests)

[LIN Yu (lin-yu)]

Hi Joël ,

The description is corrected.
Thanks for your quick reply and explanation. I will follow that.

BR,
On 09/12/2013 04:39 PM, Joël Grand-Guillaume @ camptocamp wrote:
> Review: Needs Fixing code review, no tests
>
> Dear Lyn,
>
>
> Thanks you for the corrections ! A little tips about Launchpad, you should not make a "Resubmit" yourself, because now, you're a reviewer of your own MP. Nothing important, just to let you know. Better in that case, just commit the changes, push and make a simple comment in the thread about it, like : It's corrected :)
>
> The code looks fine to me now, it would be very much appreciated to have the infos of the index.html in the description of the __openerp__.py file => lots of people look at it to know more on a module, can you add that to it :
>
> """
> This module categorizes each product item by supplier.It allows for users to be able to view a compiled list of products supplied by the supplier. Users can also directly add new products to the supplier's list.
> """
>
> Thanks a lot, this little module looks very useful to me !
>
> Regards,
>
> Joël
>

--
LIN Yu

LIN Yu
/Project Manager/
--
*Elico Corporation, Shanghai
/OpenERP Premium Certified Training Partner/ *
Cell: + 86 186 1691 1351
Office: + 86 21 6211 8017/27
Skype: llccluf
<email address hidden> <mailto:<email address hidden>>
http://www.elico-corp.com

Elico Corp

[LIN Yu (lin-yu)]

Hi Joël,

The description is updated.

Thanks for your explanation. I will get used to it.

BR,
On 09/12/2013 04:39 PM, Joël Grand-Guillaume @ camptocamp wrote:
> Review: Needs Fixing code review, no tests
>
> Dear Lyn,
>
>
> Thanks you for the corrections ! A little tips about Launchpad, you should not make a "Resubmit" yourself, because now, you're a reviewer of your own MP. Nothing important, just to let you know. Better in that case, just commit the changes, push and make a simple comment in the thread about it, like : It's corrected :)
>
> The code looks fine to me now, it would be very much appreciated to have the infos of the index.html in the description of the __openerp__.py file => lots of people look at it to know more on a module, can you add that to it :
>
> """
> This module categorizes each product item by supplier.It allows for users to be able to view a compiled list of products supplied by the supplier. Users can also directly add new products to the supplier's list.
> """
>
> Thanks a lot, this little module looks very useful to me !
>
> Regards,
>
> Joël
>

--
LIN Yu

LIN Yu
/Project Manager/
--
*Elico Corporation, Shanghai
/OpenERP Premium Certified Training Partner/ *
Cell: + 86 186 1691 1351
Office: + 86 21 6211 8017/27
Skype: llccluf
<email address hidden> <mailto:<email address hidden>>
http://www.elico-corp.com

Elico Corp

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Hi Lin,

Thanks for the corrections, it now LGTM. I mark it as approved, but I just saw one little thing more here :

0 + 'depends': ['product','stock'],#TO REMOVE joomlaconnector for standard

=> You should remove the comment about "joomlconnector", that doesn't make any sense I think

Regards,

Joël

review: Approve (code review, no tests)

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Lin Yu, what a good contribution! Thank you.

Let me make some suggestions:

 * Change menu name from 'Product suppliers' to 'Products by supplier'.
 * For delivery time, it's better to make the average for the group total.
 * With the new screen you have prepared, old view for entering supplier info from "Procurement" tab in "Product" form has been overwritten with two side effects:
   a) There is a new field called "Product Name", that is the product_id that must be hidden and filled automatically by context.
   b) There is no access to prices by quantities from this view when you select in Settings > Configuration > Purchases, "Manage pricelist per supplier".

On technical side, flake8 returns this output:

__init__.py:22:1: F401 'product' imported but unused
__init__.py:23:66: W292 no newline at end of file
__openerp__.py:32:80: E501 line too long (94 > 79 characters)
__openerp__.py:37:13: E203 whitespace before ':'
__openerp__.py:38:26: E231 missing whitespace after ','
__openerp__.py:38:36: E261 at least two spaces before inline comment
__openerp__.py:38:36: E262 inline comment should start with '# '
product.py:24:1: F401 'tools' imported but unused
product.py:25:1: F401 '_' imported but unused
product.py:28:1: E302 expected 2 blank lines, found 1
product.py:30:1: W293 blank line contains whitespace
product.py:31:80: E501 line too long (90 > 79 characters)
product.py:45:1: W293 blank line contains whitespace
product.py:46:13: E225 missing whitespace around operator
product.py:47:21: E203 whitespace before ':'
product.py:47:80: E501 line too long (114 > 79 characters)
product.py:48:24: E203 whitespace before ':'
product.py:48:61: E231 missing whitespace after ','
product.py:48:80: E501 line too long (96 > 79 characters)
product.py:48:83: E231 missing whitespace after ','
product.py:49:21: E128 continuation line under-indented for visual indent
product.py:49:79: E231 missing whitespace after ','
product.py:49:80: E501 line too long (106 > 79 characters)
product.py:50:28: E203 whitespace before ':'
product.py:50:65: E231 missing whitespace after ','
product.py:50:80: E501 line too long (100 > 79 characters)
product.py:50:87: E231 missing whitespace after ','
product.py:51:21: E128 continuation line under-indented for visual indent
product.py:51:79: E231 missing whitespace after ','
product.py:51:80: E501 line too long (109 > 79 characters)
product.py:54:66: W292 no newline at end of file
product_view.xml:1:2: E901 SyntaxError: invalid syntax
product_view.xml:1:14: E225 missing whitespace around operator
product_view.xml:1:29: E225 missing whitespace around operator
product_view.xml:2:9: E225 missing whitespace around operator
product_view.xml:3:5: E113 unexpected indentation
product_view.xml:3:5: E225 missing whitespace around operator
product_view.xml:3:10: E225 missing whitespace around operator
product_view.xml:5:9: E113 unexpected indentation
product_view.xml:5:9: E225 missing whitespace around operator
product_view.xml:5:19: E225 missing whitespace around operator
product_view.xml:5:60: E225 missing whitespace around operator
product_view.xml:5:73: E225 missing whitespace around operator
product_view.xml:6:13: E113 unexpected inde...

review: Needs Fixing (code review and test)

[lp:~lin-yu/purchase-wkfl/add_product_supplier_info]

18. By LIN Yu on 2013-09-12

[FIX] Change descriptions

19. By LIN Yu on 2013-09-16

[FIX]for flake8 rules

[LIN Yu (lin-yu)]

Hi Pedro,

I have adapted the code with flake8 rule and changed the menu name.
For field 'product_name', I think it means 'supplier name', which is not in data product yet. So we should manual enter it.

BR,

[Pedro Manuel Baeza (pedro.baeza)]

Hi Lin,

This is what I mean: this is the screen in Purchases > Products > Products before installing the module:

http://s975.photobucket.com/user/nickPT/media/before_zps8c7c40ca.png.html

And this is the aspect when you install the module:

http://s975.photobucket.com/user/nickPT/media/after_zps66577973.png.html

You can see that it appears the field called "Product Name", that corresponds to product_id, which has no sense in this screen. You aren't also be able to edit prices per quantities with your new screen. The solution is to inherit the form and define a lower priority, selecting explicitly that form on your menu action. Let me know if I can help you with code.

Another thing: please correct mixed indentations (tabs and spaces) on XML file.

Regards.

review: Needs Fixing (test)

[lp:~lin-yu/purchase-wkfl/add_product_supplier_info]

20. By LIN Yu on 2013-09-17

[FIX] Tree View priorities, xml indentation

[LIN Yu (lin-yu)]

Hi Pedro,

Thanks for your reply.

I have changed the view for the original supplier info in product form,
changed "product name" to product, corrected the indent space in XML file.
For the price, there are no price field in this object. Do you mean the
quantity field?

BTW, how can I do a average for field like 'lead time' in group by tree
view?

BR,
On 09/16/2013 09:25 PM, Pedro Manuel Baeza wrote:
> Review: Needs Fixing test
>
> Hi Lin,
>
> This is what I mean: this is the screen in Purchases > Products > Products before installing the module:
>
> http://s975.photobucket.com/user/nickPT/media/before_zps8c7c40ca.png.html
>
> And this is the aspect when you install the module:
>
> http://s975.photobucket.com/user/nickPT/media/after_zps66577973.png.html
>
> You can see that it appears the field called "Product Name", that corresponds to product_id, which has no sense in this screen. You aren't also be able to edit prices per quantities with your new screen. The solution is to inherit the form and define a lower priority, selecting explicitly that form on your menu action. Let me know if I can help you with code.
>
> Another thing: please correct mixed indentations (tabs and spaces) on XML file.
>
> Regards.

--
LIN Yu

LIN Yu
/Project Manager/
--
*Elico Corporation, Shanghai
/OpenERP Premium Certified Training Partner/ *
Cell: + 86 186 1691 1351
Office: + 86 21 6211 8017/27
Skype: llccluf
<email address hidden> <mailto:<email address hidden>>
http://www.elico-corp.com

Elico Corp

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Lin,

I have made an MP with some fixes to your branch. This is the summary:

- Put image as screenshot in module.
- Change image path.
- Remove in html description commercial references (this is by community agreement).
- Put all XML indentation as spaces.
- Remove overwrite of the product_id field to avoid future problems.
- Change function for retrieving data accordingly.

I have been trying to hide product_id field when you open the view from product form, but I can't get it, so for now I think is enough.

Thanks for your patience.

Regards.

[lp:~lin-yu/purchase-wkfl/add_product_supplier_info]

21. By LIN Yu on 2013-10-10

[MERGE] From community

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Hi,

l.127 the context is not propagated to the browse() method

review: Needs Fixing

[lp:~lin-yu/purchase-wkfl/add_product_supplier_info]

22. By LIN Yu on 2013-11-12

[FIX] propagate context

[LIN Yu (lin-yu)]

Code fixed. Proposal resubmitted.

On 11/11/2013 09:32 PM, Guewen Baconnier @ Camptocamp wrote:
> Review: Needs Fixing
>
> Hi,
>
> l.127 the context is not propagated to the browse() method

--
LIN Yu

LIN Yu
/Project Manager/
--
*Elico Corporation, Shanghai
/OpenERP Premium Certified Training Partner/ *
Cell: + 86 186 1691 1351
Office: + 86 21 6211 8017/27
Skype: llccluf
<email address hidden> <mailto:<email address hidden>>
http://www.elico-corp.com

Elico Corp

[LIN Yu (lin-yu)]

Sorry for the resubmit. I am still not familiar with the process.

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Lin,

I think it's all OK for now, but I would change the module name to get a more significant one: for example, product_by_supplier, instead of the generic one product_supplier_info, that is actually the name of one model.

Regards.

review: Approve

Unmerged revisions

=== added directory 'product_supplier_info'
=== added file 'product_supplier_info/__init__.py'
--- product_supplier_info/__init__.py	1970-01-01 00:00:00 +0000
+++ product_supplier_info/__init__.py	2013-11-12 01:44:47 +0000
@@ -0,0 +1,24 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (c) 2010-2013 Elico Corp. All Rights Reserved.
+#    Author: Yannick Gouin <[e-mail]>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+from . import product
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'product_supplier_info/__openerp__.py'
--- product_supplier_info/__openerp__.py	1970-01-01 00:00:00 +0000
+++ product_supplier_info/__openerp__.py	2013-11-12 01:44:47 +0000
@@ -0,0 +1,52 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (c) 2010-2013 Elico Corp. All Rights Reserved.
+#    Author: LIN Yu <[e-mail]>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name': 'Product Supplier Info',
+    'version': '1.0',
+    'category': 'purchase',
+    'sequence': 19,
+    'summary': 'Product Supplier Info',
+    'description': """
+This module categorizes each product item by supplier.
+======================================================
+* It allows for users to be able to view a compiled list of products supplied \
+by the supplier.
+* Users can also directly add new products to the supplier's list.
+    """,
+    'author': 'Elico Corp',
+    'website': 'http://www.elico-corp.com',
+    'images': [
+               'static/images/product_supplier_info.png'
+               ],
+    'depends': ['product', 'stock'],
+    'data': [
+        'product_view.xml',
+    ],
+    'test': [],
+    'demo': [],
+    'installable': True,
+    'auto_install': False,
+    'application': False,
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'product_supplier_info/product.py'
--- product_supplier_info/product.py	1970-01-01 00:00:00 +0000
+++ product_supplier_info/product.py	2013-11-12 01:44:47 +0000
@@ -0,0 +1,56 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (c) 2010-2013 Elico Corp. All Rights Reserved.
+#    Author: Yannick Gouin <[e-mail]>
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it wil    l be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+from openerp.osv import orm, fields
+import openerp.addons.decimal_precision as dp
+
+
+class product_supplierinfo(orm.Model):
+    _inherit = 'product.supplierinfo'
+
+    def _product_available(
+            self, cr, uid, ids, field_names=None, arg=False, context=None):
+        context = context or {}
+        res = {}
+        product_obj = self.pool.get('product.product')
+        for record in self.browse(cr, uid, ids, context=context):
+            res[record.id] = {}
+            product = product_obj.browse(cr, uid, record.product_id.id, context=context)
+            res[record.id]['qty_available'] = product.qty_available
+            res[record.id]['virtual_available'] = product.virtual_available
+        return res
+
+    _columns = {
+        # It cannot be done with related fields because product_id points to
+        # product.template, not product.product
+        'qty_available': fields.function(
+            _product_available, multi='qty_available', type='float',
+            string="Quantity On Hand"),
+        'virtual_available': fields.function(
+            _product_available, multi='virtual_available', type='float',
+            string="Forecasted Quantity"),
+        'delay' : fields.integer('Delivery Lead Time', required=True,
+                                 group_operator="avg",
+                                 help="Lead time in days between the confirmation of the purchase order and the reception of the products in your warehouse. Used by the scheduler for automatic computation of the purchase order planning."
+                                 ),
+    }
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'product_supplier_info/product_view.xml'
--- product_supplier_info/product_view.xml	1970-01-01 00:00:00 +0000
+++ product_supplier_info/product_view.xml	2013-11-12 01:44:47 +0000
@@ -0,0 +1,75 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<openerp>
+    <data>
+        <record id="view_product_supplierinfo_search" model="ir.ui.view">
+            <field name="name">product.supplierinfo.search</field>
+            <field name="model">product.supplierinfo</field>
+            <field name="arch" type="xml">
+                <search string="Product Supplier Info">
+                    <field name="name" string="Supplier"/>
+                    <field name="product_code" string="Supplier Product Code"/>
+                    <field name="product_name" string="Supplier Product Code"/>
+                    <field name="product_id" />
+                    <group expand='1' string='Group by...' groups="base.group_extended">
+                       <filter string='Product Code' name='supplier_code' icon="terp-stock_symbol-selection" 
+                            domain="[]" context="{'group_by' : 'product_code'}" />
+                       <filter string='Product' name='product' icon="terp-stock_symbol-selection" domain="[]" 
+                            context="{'group_by' : 'product_id'}" />
+                       <filter string='Supplier' name='supplier' icon="terp-stock_symbol-selection" domain="[]"
+                            context="{'group_by' : 'name'}" />
+                    </group>
+                </search>
+            </field>
+        </record>
+
+        <record id="view_product_supplierinfo_tree1" model="ir.ui.view">
+            <field name="name">product.supplierinfo.tree1</field>
+            <field name="model">product.supplierinfo</field>
+            <field name="priority">90</field>
+            <field name="arch" type="xml">
+                <tree string="Supplier Information" editable="top">
+                    <field name="sequence" widget="handle"/>
+                    <field name="product_code" string="Supplier Product Code"/>
+                    <field name="product_name" string="Supplier Product Name"/>
+                    <field name="product_id" string="Product"/>
+                    <field name="name"/>
+                    <field name="delay"/>
+                    <field name="qty_available"/>
+                    <field name="virtual_available"/>
+                    <field name="min_qty"/>
+                    <field name="company_id" groups="base.group_multi_company" widget="selection"/>
+                </tree>
+            </field>
+        </record>
+
+        <record id="view_product_supplierinfo_form1" model="ir.ui.view">
+            <field name="name">product.supplierinfo.form1</field>
+            <field name="model">product.supplierinfo</field>
+            <field name="inherit_id" ref="product.product_supplierinfo_form_view"/>
+            <field name="priority">99</field>
+            <field name="arch" type="xml">
+                <xpath expr="//field[@name='sequence']" position="before">
+                    <field name="product_id"/>
+                </xpath>
+            </field>
+        </record>
+
+        <record id="action_product_supplier_info" model="ir.actions.act_window">
+            <field name="name">Product Supplier Info</field>
+            <field name="res_model">product.supplierinfo</field>
+            <field name="type">ir.actions.act_window</field>
+            <field name="view_type">form</field>
+            <field name="view_mode">tree,form</field>
+            <field name="view_id" ref="view_product_supplierinfo_tree1"/>
+            <field name="search_view_id" ref="view_product_supplierinfo_search"/>
+            <field name="context">{'search_default_supplier':1,'group_by':[]}</field>
+        </record>
+
+        <menuitem
+            id="menu_product_supplier_info"
+            name="Product by Suppliers"
+            sequence="15"
+            action="action_product_supplier_info"
+            parent="purchase.menu_procurement_management_product"/>
+    </data>
+</openerp>

=== added directory 'product_supplier_info/static'
=== added directory 'product_supplier_info/static/description'
=== added file 'product_supplier_info/static/description/index.html'
--- product_supplier_info/static/description/index.html	1970-01-01 00:00:00 +0000
+++ product_supplier_info/static/description/index.html	2013-11-12 01:44:47 +0000
@@ -0,0 +1,12 @@
+<section class="oe_container">
+    <div class="oe_row">
+    <h2 class="oe_slogan">product_supplier_info Module</h2> 
+    <h3 class="oe_slogan">Categorise supplier product by Supplier name</h3>
+       <p>This module categorizes each product item by supplier.It allows for users to be able to view a compiled list of products supplied by the supplier.  </p>
+               
+                <p>Users can also directly add new products to the supplier's list.</p>
+        <div class="oe_row_img oe_centered oe_mt32">
+            <img class="oe_picture oe_screenshot" src="../images/product_supplier_info.png">
+        </div>
+    </div>
+</section>

=== added directory 'product_supplier_info/static/images'
=== added file 'product_supplier_info/static/images/product_supplier_info.png'
Binary files product_supplier_info/static/images/product_supplier_info.png	1970-01-01 00:00:00 +0000 and product_supplier_info/static/images/product_supplier_info.png	2013-11-12 01:44:47 +0000 differ