Code review comment for lp:~lightyear/storm/variable_cache_size

Revision history for this message
Thomas Herve (therve) wrote :

There are some small things to fix in the branch:

[1]
+"""
+The number of objects the cache should have per default.
+"""
+DEFAULT_CACHE_SIZE = 100

The documentation here is useless, a simple python comment would be better

[2]
+ @keyword cache_size: the amount of objects the internal cache should
+ keep alive

Please use @param here, @keyword is for something different. Also, the description should probably say "the maximum amount of objects".

[3]
+ assert variable_size != DEFAULT_CACHE_SIZE

This assert looks useless. If you want to keep it, use assertNotEquals.

Thanks, and sorry for not looking at that sooner.

« Back to merge proposal