Merge lp:~lightyear/storm/variable_cache_size into lp:storm

[Thomas Herve]

[Thomas Herve (therve)]

There are some small things to fix in the branch:

[1]
+"""
+The number of objects the cache should have per default.
+"""
+DEFAULT_CACHE_SIZE = 100

The documentation here is useless, a simple python comment would be better

[2]
+ @keyword cache_size: the amount of objects the internal cache should
+ keep alive

Please use @param here, @keyword is for something different. Also, the description should probably say "the maximum amount of objects".

[3]
+ assert variable_size != DEFAULT_CACHE_SIZE

This assert looks useless. If you want to keep it, use assertNotEquals.

Thanks, and sorry for not looking at that sooner.

[lp:~lightyear/storm/variable_cache_size]

260. By Benjamin Kampmann on 2008-10-14

comment and documentation

261. By Benjamin Kampmann on 2008-10-14

better way to ensure that the variable size is different from the default one

[James Henstridge (jamesh)]

Looks pretty good, but there are a few white-space issues that should be fixed. As per PEP-8, there should be two blank lines between top level functions/classes/etc. In storm/store.py you seem to have three blank lines, and in tests/store/base.py you have a single blank line.

review: Approve

[lp:~lightyear/storm/variable_cache_size]

262. By Benjamin Kampmann <email address hidden> on 2008-10-19

blank lines

[Benjamin Kampmann (lightyear)]

Changes done and pushed

[Jamu Kakar (jkakar)]

Look great, thanks! I'll clean up a couple of minor whitespace
issues and merge the branch for you.

review: Approve