Code review comment for lp:~lifeless/ubuntu/maverick/pyrex/fixdepends

Revision history for this message
Robert Collins (lifeless) wrote :

On Wed, Jun 16, 2010 at 10:50 PM, James Westby
<email address hidden> wrote:
> Review: Needs Information
> Hi,
>
> I think the Recommends: python-all-dev is sufficient. Most people will
> have it installed, but in some unusual cases.
>
> What makes you think it is insufficient?

So there are two things;
* python-all-dev is about having *all supported* python headers
installed, python-dev is about the default python's headers and static
library, according to their packages.
 * is recommends enough?

For the former point, if someone has unusual needs, they can obviously
do whatever, so it's not really a big deal, for packages I'd be
build-deping on -all-dev, but this isn't for package builds.

For the latter point, pyrex really is quite useless without the python
headers installed. Yes you can in theory build a pyrex file to use
elsewhere, but I've never encountered someone doing that - and you'd
want to QA the thing thats generated anway.

« Back to merge proposal