Merge lp:~lifeless/ubuntu/maverick/pyrex/fixdepends into lp:ubuntu/maverick/pyrex

Proposed by Robert Collins on 2010-06-16
Status: Rejected
Rejected by: Robert Collins on 2011-11-28
Proposed branch: lp:~lifeless/ubuntu/maverick/pyrex/fixdepends
Merge into: lp:ubuntu/maverick/pyrex
Diff against target: 27 lines (+8/-1)
2 files modified
debian/changelog (+7/-0)
debian/control (+1/-1)
To merge this branch: bzr merge lp:~lifeless/ubuntu/maverick/pyrex/fixdepends
Reviewer Review Type Date Requested Status
James Westby (community) 2010-06-16 Needs Information on 2010-06-16
Review via email: mp+27667@code.launchpad.net

Description of the change

Please be depending on things needed to use pyrex. For the meerkat. Not the market.

To post a comment you must log in.
James Westby (james-w) wrote :

Hi,

I think the Recommends: python-all-dev is sufficient. Most people will
have it installed, but in some unusual cases.

What makes you think it is insufficient?

Thanks,

James

review: Needs Information
Robert Collins (lifeless) wrote :

On Wed, Jun 16, 2010 at 10:50 PM, James Westby
<email address hidden> wrote:
> Review: Needs Information
> Hi,
>
> I think the Recommends: python-all-dev is sufficient. Most people will
> have it installed, but in some unusual cases.
>
> What makes you think it is insufficient?

So there are two things;
* python-all-dev is about having *all supported* python headers
installed, python-dev is about the default python's headers and static
library, according to their packages.
 * is recommends enough?

For the former point, if someone has unusual needs, they can obviously
do whatever, so it's not really a big deal, for packages I'd be
build-deping on -all-dev, but this isn't for package builds.

For the latter point, pyrex really is quite useless without the python
headers installed. Yes you can in theory build a pyrex file to use
elsewhere, but I've never encountered someone doing that - and you'd
want to QA the thing thats generated anway.

James Westby (james-w) wrote :

On Wed, 16 Jun 2010 11:13:24 -0000, Robert Collins <email address hidden> wrote:
> For the latter point, pyrex really is quite useless without the python
> headers installed. Yes you can in theory build a pyrex file to use
> elsewhere, but I've never encountered someone doing that - and you'd
> want to QA the thing thats generated anway.

It seems to me that Recommends is entirely appropriate then.

Thanks,

James

Unmerged revisions

15. By Robert Collins on 2010-06-16

Depend on python-dev - it supplies the python headers needed to build the C
files pyrex generates.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2009-05-24 01:03:02 +0000
3+++ debian/changelog 2010-06-16 04:08:26 +0000
4@@ -1,3 +1,10 @@
5+pyrex (0.9.8.5-1ubuntu3) lucid; urgency=low
6+
7+ * Depend on python-dev - it supplies the python headers needed to build the C
8+ files pyrex generates.
9+
10+ -- Robert Collins <robertc@robertcollins.net> Wed, 16 Jun 2010 16:04:16 +1200
11+
12 pyrex (0.9.8.5-1ubuntu2) karmic; urgency=low
13
14 * Fix deprecation warning in Pyrex/Compiler/Errors.py (LP: #379754)
15
16=== modified file 'debian/control'
17--- debian/control 2009-05-04 21:48:56 +0000
18+++ debian/control 2010-06-16 04:08:26 +0000
19@@ -13,7 +13,7 @@
20
21 Package: python-pyrex
22 Architecture: all
23-Depends: ${python:Depends}, ${misc:Depends}
24+Depends: ${python:Depends}, ${misc:Depends}, python-dev
25 Provides: ${python:Provides}
26 Recommends: python-all-dev
27 XB-Python-Version: all

Subscribers

People subscribed via source and target branches

to all changes: