Code review comment for lp:~lifeless/bzr/bug-413957

Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> Robert Collins has proposed merging lp:~lifeless/bzr/bug-413957 into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
>
> This 'bug' was simply a test that wants to test Pack repo's packing
> logic specifically assuming that the default format was pack-0.92.
>
> -Rob
>
>

I should mention that RepositoryFormat2a *also* sorts revisions in
reverse topological order. I didn't look at the details of the test
case, but my guess is that it might be failing because it is poking at
the details of the index. Certainly we had a similar test in
"test_pack_repository" that was updated to work with both CHK and
KnitPack repos.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqJXLUACgkQJdeBCYSNAANbagCgh9oozLWoqrLgDL4JgWFFLcFd
qdgAniCX8YDIlk90AOzPARYsf0xE8kgy
=RKs7
-----END PGP SIGNATURE-----

« Back to merge proposal