Merge lp:~lifeless/bzr/bug-413957 into lp:~bzr/bzr/trunk-old

Proposed by Robert Collins
Status: Merged
Merged at revision: not available
Proposed branch: lp:~lifeless/bzr/bug-413957
Merge into: lp:~bzr/bzr/trunk-old
Diff against target: 12 lines
To merge this branch: bzr merge lp:~lifeless/bzr/bug-413957
Reviewer Review Type Date Requested Status
Andrew Bennetts Approve
Review via email: mp+10231@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Robert Collins (lifeless) wrote :

This 'bug' was simply a test that wants to test Pack repo's packing
logic specifically assuming that the default format was pack-0.92.

-Rob

--

Revision history for this message
Andrew Bennetts (spiv) :
review: Approve
Revision history for this message
John A Meinel (jameinel) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> Robert Collins has proposed merging lp:~lifeless/bzr/bug-413957 into lp:bzr.
>
> Requested reviews:
> bzr-core (bzr-core)
>
> This 'bug' was simply a test that wants to test Pack repo's packing
> logic specifically assuming that the default format was pack-0.92.
>
> -Rob
>
>

I should mention that RepositoryFormat2a *also* sorts revisions in
reverse topological order. I didn't look at the details of the test
case, but my guess is that it might be failing because it is poking at
the details of the index. Certainly we had a similar test in
"test_pack_repository" that was updated to work with both CHK and
KnitPack repos.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkqJXLUACgkQJdeBCYSNAANbagCgh9oozLWoqrLgDL4JgWFFLcFd
qdgAniCX8YDIlk90AOzPARYsf0xE8kgy
=RKs7
-----END PGP SIGNATURE-----

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'bzrlib/tests/test_repository.py'
2--- bzrlib/tests/test_repository.py 2009-08-14 04:11:42 +0000
3+++ bzrlib/tests/test_repository.py 2009-08-17 20:36:00 +0000
4@@ -1349,7 +1349,7 @@
5 """Tests for the packs repository Packer class."""
6
7 def test_pack_optimizes_pack_order(self):
8- builder = self.make_branch_builder('.')
9+ builder = self.make_branch_builder('.', format="1.9")
10 builder.start_series()
11 builder.build_snapshot('A', None, [
12 ('add', ('', 'root-id', 'directory', None)),