Code review comment for ~libvirt-maintainers/ubuntu/+source/libvirt:ubuntu/disco-5.0

For this added delta:
    d/rules: strip -Bsymbolic-functions from linker flags as it breaks libvirt tests

    Signed-off-by: Christian Ehrhardt <email address hidden>

diff --git a/debian/rules b/debian/rules
index 12715b693d..4c581a1fd2 100755
--- a/debian/rules
+++ b/debian/rules
@@ -3,6 +3,11 @@
 DEB_RELEASE=$(shell dpkg-parsechangelog -SVersion | sed 's/[^-]\+-//')
 DEB_BUILDDATE=$(shell dpkg-parsechangelog -SDate)
 DEB_BUILDUSER=$(shell dpkg-parsechangelog -SMaintainer)
+
+# This is a default flag in Ubuntu only, but breaks the self tests as
+# required mockups are no more called
+export DEB_LDFLAGS_MAINT_STRIP=-Wl,-Bsymbolic-functions

Would you consider the approach below, taken from other packages (autofs in this case) where it was also needed? Then it could be submitted to debian:

ifeq ($(shell dpkg-vendor --derives-from Ubuntu && echo yes),yes)
  export DEB_LDFLAGS_MAINT_STRIP = -Wl,-Bsymbolic-functions
endif