Code review comment for lp:~leonardr/launchpadlib/529348-fix

Revision history for this message
Gary Poster (gary) wrote :

gary_poster: leonardr: do I understand correctly that this will change nothing about the change needed now for 529348 in launchpad, because of legacy?
leonardr: gary: yes, this is 1) to get the tests passing, and 2) to simplify the 529348 fix a little bit many years from now
gary_poster: leonardr: right. Getting the test to pass this way is expedient. We actually have an explicit test to show the hack needed in launchpad. Understood. Approving branch.

« Back to merge proposal