Merge lp:~leonardr/launchpadlib/529348-fix into lp:launchpadlib
Proposed by
Leonard Richardson
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Gary Poster | ||||
Approved revision: | 86 | ||||
Merged at revision: | not available | ||||
Proposed branch: | lp:~leonardr/launchpadlib/529348-fix | ||||
Merge into: | lp:launchpadlib | ||||
Diff against target: |
71 lines (+15/-5) 3 files modified
src/launchpadlib/NEWS.txt (+7/-0) src/launchpadlib/__init__.py (+1/-1) src/launchpadlib/credentials.py (+7/-4) |
||||
To merge this branch: | bzr merge lp:~leonardr/launchpadlib/529348-fix | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gary Poster | Approve | ||
Review via email: mp+21494@code.launchpad.net |
Description of the change
This branch ensures that when launchpadlib communicates with the Launchpad website (as opposed to the web service), it always sets the Referer header. In a very long time (once the versions of Ubuntu containing earlier versions of launchpadlib are at end-of-life) this will let us get rid of special hacks allowing clients to POST to certain URLs without specifying the Referer header.
To post a comment you must log in.
gary_poster: leonardr: do I understand correctly that this will change nothing about the change needed now for 529348 in launchpad, because of legacy?
leonardr: gary: yes, this is 1) to get the tests passing, and 2) to simplify the 529348 fix a little bit many years from now
gary_poster: leonardr: right. Getting the test to pass this way is expedient. We actually have an explicit test to show the hack needed in launchpad. Understood. Approving branch.