Code review comment for lp:~le-chi-thu/lava-dispatcher/rapport-result-submit-failures

Revision history for this message
Michael Hudson-Doyle (mwhudson) wrote :

Huh, missed this. Sorry about that. Seems fine, I'll merge it -- with one tweak: I don't think we should trap the exception from submit_job, because we still want the dispatcher to exit with code 1 if the submit action fails.

review: Approve

« Back to merge proposal