Merge lp:~le-chi-thu/lava-dispatcher/rapport-result-submit-failures into lp:lava-dispatcher

[Le Chi Thu]

When the dispatcher fail to submit the test result, the error was not handle correctly and there is not logging so the summary page did not tell why the job not complete.

http://validation.linaro.org/lava-server/scheduler/job/17614

See the current error msg here.
http://validation.linaro.org/lava-server/scheduler/job/17614/log_file#entry26

[lp:~le-chi-thu/lava-dispatcher/rapport-result-submit-failures]

280. By Le Chi Thu <email address hidden> <email address hidden> on 2012-05-10

Synched with trunk and fix a typo error

[Michael Hudson-Doyle (mwhudson)]

Huh, missed this. Sorry about that. Seems fine, I'll merge it -- with one tweak: I don't think we should trap the exception from submit_job, because we still want the dispatcher to exit with code 1 if the submit action fails.

review: Approve

=== modified file 'lava_dispatcher/job.py'
--- lava_dispatcher/job.py	2012-05-08 22:03:24 +0000
+++ lava_dispatcher/job.py	2012-05-10 20:04:22 +0000
@@ -85,7 +85,7 @@
             'items': {'type': 'string'},
             'optional': True,
             },
-        }, 
+        },
     }
 
 
@@ -143,7 +143,7 @@
         if 'device_type' in self.job_data:
             metadata['target.device_type'] = self.job_data['device_type']
         self.context.test_data.add_metadata(metadata)
-        
+
         self.context.test_data.add_tags(self.tags)
 
         try:
@@ -190,7 +190,11 @@
                 params = submit_results.get('parameters', {})
                 action = lava_commands[submit_results['command']](
                     self.context)
-                action.run(**params)
+                try:
+                    logging.info("Submiting the test result with parameters = %s", params)
+                    action.run(**params)
+                except Exception as err:
+                    logging.error("Failed to submit the test result. Error = %s", err)
 
     def _set_logging_level(self):
         # set logging level is optional