Code review comment for lp:~lazypower/charms/precise/mongodb/tests

Revision history for this message
Matt Bruzek (mbruzek) wrote :

Looks good Chuck. I had a few comments on the setup script.

https://codereview.appspot.com/56640044/diff/1/tests/00_setup.sh
File tests/00_setup.sh (right):

https://codereview.appspot.com/56640044/diff/1/tests/00_setup.sh#newcode3
tests/00_setup.sh:3: sudo apt-get install python-setuptools
What about python3-setuptools ?
Add -y to make the script non-interactive.

https://codereview.appspot.com/56640044/diff/1/tests/00_setup.sh#newcode6
tests/00_setup.sh:6: sudo add-apt-repository ppa:juju/stable
If you add the new repository I think you need to apt-get update
Also add the -y flag to make the script non-interactive.

https://codereview.appspot.com/56640044/diff/1/tests/00_setup.sh#newcode9
tests/00_setup.sh:9: sudo apt-get install amulet python3
python3-requests python3-pymongo juju-core charm-tools
Add the -y flag to make the script non-interactive.

https://codereview.appspot.com/56640044/

« Back to merge proposal