Merge lp:~lazypower/charms/precise/mongodb/tests into lp:charms/mongodb

[Charles Butler]

added amulet testing scaffold

Deploys a set similar to the bundle, with 2 shards, a mongo shell, and
configserver. Tests reachability of the ManagementUI, and accessability
between nodes, validates setup by issuing service mongodb status

https://codereview.appspot.com/56640044/

[Charles Butler (lazypower)]

Reviewers: mp+203560_code.launchpad.net,

Message:
Please take a look.

Description:
added amulet testing scaffold

Deploys a set similar to the bundle, with 2 shards, a mongo shell, and
configserver. Tests reachability of the ManagementUI, and accessability
between nodes, validates setup by issuing service mongodb status

https://code.launchpad.net/~lazypower/charms/precise/mongodb/tests/+merge/203560

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/56640044/

Affected files (+118, -0 lines):
   A [revision details]
   A tests/00_setup.sh
   A tests/200_deploy.test

[Matt Bruzek (mbruzek)]

Looks good Chuck. I had a few comments on the setup script.

https://codereview.appspot.com/56640044/diff/1/tests/00_setup.sh
File tests/00_setup.sh (right):

https://codereview.appspot.com/56640044/diff/1/tests/00_setup.sh#newcode3
tests/00_setup.sh:3: sudo apt-get install python-setuptools
What about python3-setuptools ?
Add -y to make the script non-interactive.

https://codereview.appspot.com/56640044/diff/1/tests/00_setup.sh#newcode6
tests/00_setup.sh:6: sudo add-apt-repository ppa:juju/stable
If you add the new repository I think you need to apt-get update
Also add the -y flag to make the script non-interactive.

https://codereview.appspot.com/56640044/diff/1/tests/00_setup.sh#newcode9
tests/00_setup.sh:9: sudo apt-get install amulet python3
python3-requests python3-pymongo juju-core charm-tools
Add the -y flag to make the script non-interactive.

https://codereview.appspot.com/56640044/

[Matt Bruzek (mbruzek)]

The python code looks good to me. +1 review from mbruzek

https://codereview.appspot.com/56640044/

[Charles Butler (lazypower)]

Thanks Matt,

I responded to one of your comments, and will push the requested
revisions. (good catch about non-interactive)

https://codereview.appspot.com/56640044/diff/1/tests/00_setup.sh
File tests/00_setup.sh (right):

https://codereview.appspot.com/56640044/diff/1/tests/00_setup.sh#newcode3
tests/00_setup.sh:3: sudo apt-get install python-setuptools
On 2014/01/28 16:02:06, mbruzek wrote:
> What about python3-setuptools ?
> Add -y to make the script non-interactive.

Python2 setup tools provides the add-apt-repository, which is the reason
behind adding that package first. I dont feel there is a need to
introduce python3-setuptools yet, as im' not familiar with what the
package provides.

https://codereview.appspot.com/56640044/

[lp:~lazypower/charms/precise/mongodb/tests]

41. By Charles Butler on 2014-01-28

Changes apt lines to be non-interactive

[Charles Butler (lazypower)]

Please take a look.

https://codereview.appspot.com/56640044/

[lp:~lazypower/charms/precise/mongodb/tests]

42. By Charles Butler on 2014-01-28

Added missing apt-get update

[Charles Butler (lazypower)]

Please take a look.

https://codereview.appspot.com/56640044/

[Marco Ceppi (marcoceppi)]

I'd like to see a more extensive test. More configuration options
exercised, and more relation data verified

https://codereview.appspot.com/56640044/diff/40001/tests/00_setup.sh
File tests/00_setup.sh (right):

https://codereview.appspot.com/56640044/diff/40001/tests/00_setup.sh#newcode11
tests/00_setup.sh:11: sudo apt-get install amulet python3
python3-requests python3-pymongo juju-core charm-tools -y
You install python3-pymongo but never use it. I'd like to see a test
which connected to mongodb from the test server

https://codereview.appspot.com/56640044/diff/40001/tests/200_deploy.test
File tests/200_deploy.test (right):

https://codereview.appspot.com/56640044/diff/40001/tests/200_deploy.test#newcode20
tests/200_deploy.test:20: d.add('shard2', charm='mongodb', units=scale)
I like this, you've really exercised the full length of the mongodb
charm

https://codereview.appspot.com/56640044/diff/40001/tests/200_deploy.test#newcode87
tests/200_deploy.test:87: d.sentry.unit['shard2/0'].relation('database',
'mongos:mongos')
You should validate the data being sent on the wire, to ensure the charm
doesn't inadvertently change and break backwards compatibility

https://codereview.appspot.com/56640044/

[lp:~lazypower/charms/precise/mongodb/tests]

43. By Charles Butler on 2014-02-03

Added pymongo validation of mongo shell connectivity

[Charles Butler (lazypower)]

Please take a look.

https://codereview.appspot.com/56640044/

[lp:~lazypower/charms/precise/mongodb/tests]

44. By Charles Butler on 2014-02-03

Removed stale comment

[Charles Butler (lazypower)]

Please take a look.

https://codereview.appspot.com/56640044/

[Marco Ceppi (marcoceppi)]

LGTM

https://codereview.appspot.com/56640044/

=== added file 'tests/00_setup.sh'
--- tests/00_setup.sh	1970-01-01 00:00:00 +0000
+++ tests/00_setup.sh	2014-02-03 22:19:04 +0000
@@ -0,0 +1,11 @@
+#!/bin/bash
+
+sudo apt-get install python-setuptools -y
+
+if [ -f '/etc/apt.d/sources.list.d/juju-stable-precise.list' ]; then
+	sudo add-apt-repository ppa:juju/stable -y
+fi
+
+sudo apt-get update
+
+sudo apt-get install amulet python3 python3-requests python3-pymongo juju-core charm-tools  -y

=== added file 'tests/200_deploy.test'
--- tests/200_deploy.test	1970-01-01 00:00:00 +0000
+++ tests/200_deploy.test	2014-02-03 22:19:04 +0000
@@ -0,0 +1,127 @@
+#!/usr/bin/env python3
+
+import amulet
+import requests
+from pymongo import MongoClient
+
+#########################################################
+# Test Quick Config
+#########################################################
+scale = 1
+seconds = 1400
+
+#########################################################
+# 3shard cluster configuration
+#########################################################
+d = amulet.Deployment()
+
+d.add('configsvr', charm='mongodb', units=scale)
+d.add('mongos', charm='mongodb', units=scale)
+d.add('shard1', charm='mongodb', units=scale)
+d.add('shard2', charm='mongodb', units=scale)
+
+#Setup the config svr
+d.configure('configsvr', {'replicaset': 'configsvr'})
+
+# define each shardset
+d.configure('shard1', {'replicaset': 'shard1'})
+d.configure('shard2', {'replicaset': 'shard2'})
+
+d.configure('mongos', {})
+
+#Connect the config servers to mongo shell
+d.relate('configsvr:configsvr', 'mongos:mongos-cfg')
+
+#connect each shard to the mongo shell
+d.relate('mongos:mongos', 'shard1:database')
+d.relate('mongos:mongos', 'shard2:database')
+d.expose('configsvr')
+d.expose('mongos')
+
+# Perform the setup for the deployment.
+try:
+    d.setup(seconds)
+    d.sentry.wait(seconds)
+except amulet.helpers.TimeoutError:
+    message = 'The environment did not setup in %d seconds.', seconds
+    amulet.raise_status(amulet.SKIP, msg=message)
+except:
+    raise
+
+sentry_dict = {
+    'config-sentry': d.sentry.unit['configsvr/0'],
+    'mongos-sentry': d.sentry.unit['mongos/0'],
+    'shard1-sentry': d.sentry.unit['shard1/0'],
+    'shard2-sentry': d.sentry.unit['shard2/0']
+}
+
+
+#############################################################
+# Check presence of MongoDB GUI HEALTH Status
+#############################################################
+def validate_status_interface():
+    r = requests.get("http://{}:28017".format(
+        sentry_dict['config-sentry'].info['public-address']),
+        verify=False)
+    r.raise_for_status
+
+
+#############################################################
+# Validate that each unit has an active mongo service
+#############################################################
+def validate_running_services():
+    for service in sentry_dict:
+        output = sentry_dict[service].run('service mongodb status')
+        service_active = str(output).find('mongodb start/running')
+        if service_active == -1:
+            message = "Failed to find running MongoDB on host {}".format(service)
+            amulet.raise_status(amulet.SKIP, msg=message)
+
+
+#############################################################
+# Validate connectivity from $WORLD
+#############################################################
+def validate_world_connectivity():
+    client = MongoClient(d.sentry.unit['mongos/0'].info['public-address'])
+
+    db = client['test']
+    #Can we successfully insert?
+    insert_id = db.amulet.insert({'assert': True})
+    if insert_id is None:
+        amulet.raise_status(amulet.FAIL, msg="Failed to insert test data")
+    #Can we delete from a shard using the Mongos hub?
+    result = db.amulet.remove(insert_id)
+    if result['err'] is not None:
+        amulet.raise_status(amulet.FAIL, msg="Failed to remove test data")
+
+
+#############################################################
+# Validate relationships
+#############################################################
+#broken pending 1273312
+def validate_relationships():
+    d.sentry.unit['configsvr/0'].relation('configsvr', 'mongos:mongos-cfg')
+    d.sentry.unit['shard1/0'].relation('database', 'mongos:mongos')
+    d.sentry.unit['shard2/0'].relation('database', 'mongos:mongos')
+    print(d.sentry.unit['shard1/0'].relation('database', 'mongos:mongos'))
+
+
+def validate_manual_connection():
+    output, code = d.sentry.unit['shard1/0'].run("mongo {}".format(
+        d.sentry.unit['mongos/0'].info['public-address']))
+    if code != 0:
+        message = "Manual Connection failed for unit shard1"
+        amulet.raise_status(amulet.SKIP, msg=message)
+
+    output, code = d.sentry.unit['shard2/0'].run("mongo {}".format(
+        d.sentry.unit['mongos/0'].info['public-address']))
+    if code != 0:
+        message = "Manual Connection failed for unit shard2"
+        amulet.raise_status(amulet.SKIP, msg=message)
+
+
+validate_status_interface()
+validate_running_services()
+#validate_relationships()
+validate_manual_connection()
+validate_world_connectivity()