Unity 8

Code review comment for lp:~larsu/unity8/lp1236413

  1. lp1236413
  2. Merge into trunk
Revision history for this message
Nick Dedekind (nick-dedekind) wrote :

I think the TimeFormatter object screams for shared private data (for dbus management).
Each message is going to be listening to the same dbus property, so we might as well connect all formatters to the same callback using qt signal.

TimeFormatter <------
TimeFormatter <------ (emit updated) TimeFormatterPrivate <------ dbus
TimeFormatter <------

review: Needs Fixing

« Back to merge proposal