Code review comment for lp:~larsu/nautilus/add-menubar-patch

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks for the work, that works nicely here!

Looking at the layout suggested in the linked bugs I've some questions/comments (I know some actions are missing which makes more difficult to add some of the items, it's fine to do without those)

- the bug description has "Edit" with the "selection section" before the "copy/cut/paste" one, the patch has the order reversed. Looking to gedit and some other apps, it seems the norm is to do what the patch is doing, let's keep it this way

- same for the view menu, let's keep the zoom at the bottom (eog does it as well)

- can we have the "view as icon/list" added?

- bookmark isn't listing the actual bookmarks, is that a bug or one of those items that would be more work to add with the current codebase/structure?

- the "go" menu is missing, same question ... technical reason or overlook? ;-)

review: Needs Information

« Back to merge proposal