View Bazaar branches
Get this repository:
git clone https://git.launchpad.net/nautilus

Nautilus has 2 active reviews. See all merge proposals.

Import details

Import Status: Reviewed

This repository is an import of the Git repository at https://gitlab.gnome.org/GNOME/nautilus.git.

The next import is scheduled to run .

Last successful import was .

Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 3 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-2 and finished taking 2 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-2 and finished taking 3 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-2 and finished taking 2 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-2 and finished taking 2 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-2 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 2 minutes — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-5 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-2 and finished taking 1 minute — see the log
Import started on juju-98ee42-prod-launchpad-codeimport-2 and finished taking 2 minutes — see the log

Branches

Name Last Modified Last Commit
wip/kabus/extract-dir-name 2024-10-06 10:32:44 UTC
list-base: Use slot to open location on drag hover

Author: Khalid Abu Shawarib
Author Date: 2024-10-06 10:32:44 UTC

list-base: Use slot to open location on drag hover

Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/3613

wip/kabus/cut-grid 2024-10-04 18:22:52 UTC
grid-cell: Use dashed border for cut style

Author: Khalid Abu Shawarib
Author Date: 2024-10-04 18:22:52 UTC

grid-cell: Use dashed border for cut style

main 2024-10-02 21:57:50 UTC
readme: Clarify xdg-user-dirs-gtk dependency

Author: Corey Berla
Author Date: 2024-09-28 16:26:51 UTC

readme: Clarify xdg-user-dirs-gtk dependency

Nautilus has quasi-depended on xdg-user-dirs-gtk, but it
has largely gone unnoticed. That is, until commit 5c2f55663ad
("placessidebar: Reorganize places"), which makes this dependency
very obvious. Along with updating localization, xdg-user-dirs-gtk
also creates the default bookmarks. Now that we are treating
the XDG locations as regular bookmarks it's critical that
the user has xdg-user-dirs-gtk installed to create the default
bookmarks. Ideally, the dependency would be installed as part of
the base install to ensure that it is executed before the
bookmark file is created elsewhere, but that's out of our control.

wip/kabus/minor-optim 2024-10-01 09:50:46 UTC
view-model: Merge iterators

Author: Khalid Abu Shawarib
Author Date: 2024-10-01 09:43:15 UTC

view-model: Merge iterators

gnome-47 2024-10-01 07:27:09 UTC
Update Norwegian Bokmål translation

Author: Brage Fuglseth
Author Date: 2024-10-01 07:27:09 UTC

Update Norwegian Bokmål translation

wip/corey/preferences 2024-09-21 16:26:54 UTC
pathbar: Stop adding extra space to buttons

Author: Corey Berla
Author Date: 2024-09-20 17:58:45 UTC

pathbar: Stop adding extra space to buttons

The minimum width on the pathbar buttons causes a single character
directory to have extra space at the end, making it lopsided
and mismatched with the other buttons.

gnome-46 2024-09-21 13:20:40 UTC
Update Thai translation

Author: Aefgh Threenine
Author Date: 2024-09-21 13:20:40 UTC

Update Thai translation

wip/kabus/batch-rename-revamp 2024-09-06 17:59:30 UTC
test/file: Add batch rename tests

Author: Khalid Abu Shawarib
Author Date: 2024-01-11 13:35:28 UTC

test/file: Add batch rename tests

wip/corey/list-length 2024-09-05 16:19:02 UTC
general: Limit use of g_list_length

Author: Corey Berla
Author Date: 2024-09-05 16:15:17 UTC

general: Limit use of g_list_length

In many cases we only care if a list is NULL or a single item but
we use g_list_length which iterates over the whole list.

wip/corey/bye-bye-deep-counts 2024-08-31 17:39:17 UTC
properties-window: Use fallback for deep counts

Author: Corey Berla
Author Date: 2024-08-31 17:39:17 UTC

properties-window: Use fallback for deep counts

The new way to calculate deep counts doesn't work on gvfs backends. Take
the existing logic, we had in directory-async, but in a much more simple
manner. In particular remove the inode check that was done in order not
to duplicate the count for hard links. That's not applicable to these
other backends, and the implementation for checking for duplicate
inodes, was slowing down the count significantly.

wip/antoniof/view-refactorings-part-10 2024-08-25 18:59:36 UTC
window-slot: Change view mode for search if needed

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2024-08-25 18:59:36 UTC

window-slot: Change view mode for search if needed

This is needed only in the case where a global search is triggered
from the Network view, in which case we want to use regular list or
grid modes, but come back to network view if this global search is
cancelled.

sam/tracker-domain-argument 2024-08-21 11:09:46 UTC
tracker-utilities: Use finish() async function for bus connections

Author: Carlos Garnacho
Author Date: 2024-08-21 11:07:52 UTC

tracker-utilities: Use finish() async function for bus connections

The fallback flatpak-local miner connection is still a D-Bus one, it
should be obtained using the bus_new_finish() call.

wip/corey/recent-windows 2024-08-19 04:11:38 UTC
files-view: Show recent windows in file chooser mode

Author: Corey Berla
Author Date: 2024-08-19 01:05:41 UTC

files-view: Show recent windows in file chooser mode

wip/corey/monitors 2024-08-16 04:53:08 UTC
directory: Avoid setting up unnecessary monitors

Author: Corey Berla
Author Date: 2024-08-16 04:46:45 UTC

directory: Avoid setting up unnecessary monitors

Generally, we setup 1 monitor for the current view directory. There have been
many requests in the past to setup monitors for subdirectories (in order to keep
directory file counts up to date), but nautilus has resisted those requests
for performance reasons and out of concern regarding inotify limits.

Despite this, we have actually been setting up many more monitors than we realized
for NautilusStarredDirectory and NautilusSearchDirectory. Those custom folders contain
files/folders that can be from a range of different parents. Each call to
file_monitor_add ends up creating a monitor for that file/folder's parent.
Ironically, commit b32d6453ad9 ("Only use directory monitors to avoid using lots
and lots of file monitors") intended to reduce the number of monitors, but these
custom directories didn't exist at that time (SearchDirectory came 3 months later
and StarredDirectory came over a decade after that).

Add a check to only monitor the directory when the call was specically to
nautilus_directory_file_monitor_add().

wip/corey/copy 2024-08-12 14:21:05 UTC
file-chooser: Add copy/paste to menu

Author: Corey Berla
Author Date: 2024-08-12 04:32:12 UTC

file-chooser: Add copy/paste to menu

wip/antoniof/global-search-from-network-view 2024-08-11 00:00:16 UTC
WIP window-slot: Fix global search from Network view

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2024-08-10 23:59:07 UTC

WIP window-slot: Fix global search from Network view

wip/antoniof/file-chooser-sushi-finish 2024-08-10 22:24:14 UTC
previewer: Remember invoker slot

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2024-08-10 21:56:53 UTC

previewer: Remember invoker slot

When users press the arrow keys while the previewer window has focus,
we emulate the same event on the files view.

However, we do this by taking the most recently focused window in the
NautilusApplication, which poses two problems:

* there is no warranty that the most recently focused NautilusWindow
  is the one which the previewer was launched from.
* FileChooser windows do not belong to NautilusApplication, so we are
  100% sure to get the wrong window in that case.

Instead of passing a GtkRoot window to show previewer, pass a slot
and keep a pointer to it around to reuse when emulating arrows back.

Closes https://gitlab.gnome.org/GNOME/nautilus/-/work_items/3428

wip/kabus/batch-rename-adw-dialog 2024-08-03 13:16:51 UTC
batch-rename-dialog: Port to AdwDialog

Author: Khalid Abu Shawarib
Author Date: 2024-02-13 11:12:42 UTC

batch-rename-dialog: Port to AdwDialog

use-adw-about-dialog 2024-07-31 11:34:31 UTC
window: Load About Dialog info from appdata file

Author: Felipe Borges
Author Date: 2024-07-29 14:53:04 UTC

window: Load About Dialog info from appdata file

By using AdwAboutDialog.new_from_appdata we can populate the About
dialog with information from the appdata file.

This is useful for downstreams that use of appdata overwrites to
change info such as support questions and issue tracker addresses.

wip/kabus/search-types-dialog-original 2024-07-30 23:09:41 UTC
window: Port to AdwAboutDialog

Author: Automeris naranja
Author Date: 2024-05-25 22:48:50 UTC

window: Port to AdwAboutDialog

(cherry picked from commit 4087cadcb90b7cb0f98d45f8cb2215a276e9c388)

wip/antoniof/filechooser 2024-07-24 14:13:06 UTC
Skip patched-mutter shenaningans for testing purposes

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2024-06-24 12:43:42 UTC

Skip patched-mutter shenaningans for testing purposes

alatiera-25f445f4-patch-7ced 2024-07-17 14:55:59 UTC
tests: Update localsearch cli name

Author: Jordan Petridis
Author Date: 2024-07-17 14:55:59 UTC

tests: Update localsearch cli name

It was renamed to drop the version number now

https://gitlab.gnome.org/GNOME/localsearch/-/merge_requests/554

wip/antoniof/files-view-cleanup-and-performance-enhancements 2024-06-15 21:37:42 UTC
files-view: Drop a couple unnecessary menu updates

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2024-06-15 20:10:07 UTC

files-view: Drop a couple unnecessary menu updates

When toggling hidden files, we reload the directory, which already
causes the context menus to be updated.

When copy or move operations are done, if they affect the current
view, we also update context menus from directory content change
signals. Also the comment is outdated, as undo/redo are not view
actions anymore, and they are updated elsewhere.

wip/antoniof/fix-fix-fix 2024-06-12 10:46:19 UTC
tests: Use localsearch3 test-sandbox

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2024-06-12 10:24:24 UTC

tests: Use localsearch3 test-sandbox

Test sandbox program has been moved from the `TinySPARQL` (previously
`tracker`) project to `localsearch` (previously `tracker-miners`).

https://gitlab.gnome.org/GNOME/tinysparql/-/commit/067e855151cf47609bdeccadd9baa314016c4152
https://gitlab.gnome.org/GNOME/localsearch/-/commit/abc100fa6b259b9281231e6c8daf27723d62a3ed

wip/p3732/separate-callbacks 2024-06-03 08:50:31 UTC
directory-async: move callbacks to separate struct

Author: Peter Eisenmann
Author Date: 2024-05-28 22:46:16 UTC

directory-async: move callbacks to separate struct

This separates callbacks from NautilusDirectoryPrivate by using a
dedicated struct for them. This allows for more clearer memory
management, as it is now handled in dedicated functions, that are called
respectively in init/finalize of NautilusDirectory.

This is in preparation for changing the underlying callback storage data
structure in upcoming commits.

wip/antoniof/sidebar-editor 2024-06-02 11:19:49 UTC
file-utilities: Allow Public folder to be added to sidebar

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2024-06-02 11:19:24 UTC

file-utilities: Allow Public folder to be added to sidebar

As a special built-in folder and not as a bookmark.

wip/p3732/dir-hash-table-rework 2024-05-15 00:25:55 UTC
general: restore original name of nautilus-directory-async

Author: Peter Eisenmann
Author Date: 2024-05-15 00:25:55 UTC

general: restore original name of nautilus-directory-async

Part of separating out callback-related directory functionality.

Step 4: Restore original name of nautilus-directory-async.c

wip/p3732/original-dir-hash-table-rework 2024-05-13 00:47:27 UTC
directory-async: emit changed only once for removed callbacks

Author: Peter Eisenmann
Author Date: 2024-02-22 12:10:54 UTC

directory-async: emit changed only once for removed callbacks

wip/p3732/selection-crash 2024-05-12 14:46:29 UTC
window-slot: Inline location loading helper

Author: Peter Eisenmann
Author Date: 2024-05-12 14:43:03 UTC

window-slot: Inline location loading helper

The bigger code block of activating a pending file only applies for one
caller, so the helper function did not deduplicate any code and really
only created more overhead, making the code harder to follow.

This commit was inspired by a crash found by Khalid Abu Shawarib.

gnome-45 2024-05-07 20:36:05 UTC
nautilus-window: Disable sidebar gestures when not collapsed

Author: Khalid Abu Shawarib
Author Date: 2024-04-29 19:38:02 UTC

nautilus-window: Disable sidebar gestures when not collapsed

Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/3419

(cherry picked from commit 729f3fb6caa69d7cf314803559b2b5214f62d1a6)

wip/antoniof/dir-hash-table-rework 2024-05-03 18:33:34 UTC
directory-async: emit changed only once for removed callbacks

Author: Peter Eisenmann
Author Date: 2024-02-22 12:10:54 UTC

directory-async: emit changed only once for removed callbacks

wip/p3732/middle-ellipsize-sidebar 2024-04-04 20:50:18 UTC
sidebar-row: ellipsize label in middle

Author: Peter Eisenmann
Author Date: 2024-03-14 23:24:23 UTC

sidebar-row: ellipsize label in middle

Sidebar entries, like folder names, tend to have interesting information
at the beginning and the end, not so much in the middle. Change the
ellipzation method accordingly.

Fixes #3010

bilelmoussaoui/fix 2024-02-25 17:39:48 UTC
chore: Remove duplicated condition

Author: Bilal Elmoussaoui
Author Date: 2024-02-25 17:39:48 UTC

chore: Remove duplicated condition

Adds an extra string to translate for nothing

wip/p3732/debug-hash-table-dummy 2024-02-21 16:04:43 UTC
DUMMY directory-async: Use hash tables for ready callbacks

Author: Peter Eisenmann
Author Date: 2024-02-21 16:04:43 UTC

DUMMY directory-async: Use hash tables for ready callbacks

This improves performance with directories that have a large number
of direct descendants. Also use the words 'unsatisfied' and 'ready'
instead of active and inactive to better describe the two types.

wip/p3732/almost-viable-clang-format-config 2024-02-17 23:28:44 UTC
An almost viable clang-format config

Author: Peter Eisenmann
Author Date: 2024-02-17 23:28:44 UTC

An almost viable clang-format config

Can't reasonably be used until [1] is fixed, as it aligns all
declarations, even outside of function definitions.

[1] https://github.com/llvm/llvm-project/issues/51202

wip/corey/short-status 2024-02-03 23:40:09 UTC
progress-info: Rename status property to short-status

Author: Corey Berla
Author Date: 2024-02-03 23:31:51 UTC

progress-info: Rename status property to short-status

For now we only use the short-status property. In the future maybe
we'll use the status property and we can add it at that point.

wip/corey/moved-flags 2024-02-03 19:31:16 UTC
test: Add test for nautilus_file_rename

Author: Corey Berla
Author Date: 2024-02-02 20:57:16 UTC

test: Add test for nautilus_file_rename

wip/kabus/snap 2024-02-03 13:50:55 UTC
build: Add WIP snap package manifest

Author: Khalid Abu Shawarib
Author Date: 2024-02-03 13:50:55 UTC

build: Add WIP snap package manifest

wip/antoniof/search-everywhere 2024-01-31 15:03:18 UTC
toolbar: Reserve folder search button space

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2024-01-30 02:11:52 UTC

toolbar: Reserve folder search button space

When the folder search button is hidden (in Search Everywhere place),
the searchbar moves to recenter in the headerbar, because a hidden
widget doesn't allocate space.

This repositioning of the search entry is obviously undesirable.

As a workaround, don't toggle GtkWidget:visible but, instead, use
a stack to swap the button for an empty box to act as its shadow.
The homogenous stack ensure the button alocated space is preserved.

46-alpha-1-release 2024-01-28 21:25:25 UTC
Release version 46.alpha.1

Author: Peter Eisenmann
Author Date: 2024-01-28 02:28:16 UTC

Release version 46.alpha.1

wip/gnome-46-alpha-1 2024-01-28 13:15:03 UTC
Release version 46.alpha.1

Author: Peter Eisenmann
Author Date: 2024-01-28 02:28:16 UTC

Release version 46.alpha.1

wip/corey/progress-indicator 2024-01-26 21:17:23 UTC
progress-info: Add comment about threadsafety

Author: Corey Berla
Author Date: 2024-01-26 02:14:50 UTC

progress-info: Add comment about threadsafety

In the header, there's a comment that indicates all functions are
thread safe, well this one function isn't.

wip/antoniof/update-starred-uris 2024-01-12 19:10:43 UTC
view-model: Drop find()

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2024-01-11 13:32:51 UTC

view-model: Drop find()

This wraps a linear search in an apparently simple call. This invites
lazy coding and invites future performance regressions.

This is not to say there is no need to iterate the model linearly. But
if when do so, it's best to do it explicitly, in a for/while loop, to
make it easy to spot performance issues.

wip/corey/batchrename 2024-01-08 23:23:04 UTC
batch-rename: Allow renaming files with regular expressions

Author: Corey Berla
Author Date: 2024-01-08 23:10:14 UTC

batch-rename: Allow renaming files with regular expressions

wip/saluy/batch-rename 2023-12-25 16:52:08 UTC
batch-rename: Use tmp filename in the case of filename "loops"

Author: Sebastian Luy
Author Date: 2020-07-26 19:39:47 UTC

batch-rename: Use tmp filename in the case of filename "loops"

Errors can occur when batch renaming files if a
new filename matches an existing filename.

Reordering the files does not solve this problem if the
filenames contain loops (ex. A -> B & B -> A).

Instead of reordering the files, give any problematic
files a temporary name and handle them after the rest of
the files have been renamed.

https://gitlab.gnome.org/GNOME/nautilus/-/issues/1443

gnome-44 2023-12-13 13:29:30 UTC
icon-info: Fix build

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2023-12-13 00:13:35 UTC

icon-info: Fix build

Previous commit relied on mixing declarations with code, which is not allowed with the build flags of this branch.

(cherry picked from commit deed9bcab051529e64e3fc1870f299233b8c200e)

gnome-43 2023-12-13 00:13:35 UTC
icon-info: Fix build

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2023-12-13 00:13:35 UTC

icon-info: Fix build

Previous commit relied on mixing declarations with code, which is not allowed with the build flags of this branch.

wip/oholy/detailed-date-original 2023-11-19 01:11:45 UTC
general: Add detailed date and time format option

Author: Ondrej Holy
Author Date: 2023-06-01 11:14:51 UTC

general: Add detailed date and time format option

The default time and date formats in Files are intended to be human
friendly and to avoid information overload. This works for most cases
and is an appropriate default. However, there are cases where people
need to be able to see a complete date and time for their files. Let's
add a user preference to show a numerical date and time format.

Resolves: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2874

wip/p3732/popovers-and-dialogs 2023-11-16 11:49:29 UTC
dummy delay commit

Author: Peter Eisenmann
Author Date: 2023-11-16 11:49:29 UTC

dummy delay commit

wip/kabus/asan 2023-11-12 01:39:31 UTC
ci: Add experimental Address Sanitizer analysis

Author: Khalid Abu Shawarib
Author Date: 2023-10-27 21:29:27 UTC

ci: Add experimental Address Sanitizer analysis

Run the tests after compiling with the address sanitizer.

wip/p3732/ups-and-downs 2023-11-03 01:44:40 UTC
window: make Alt-Down behavior symmetric to Alt-Up

Author: Peter Eisenmann
Author Date: 2023-11-03 01:41:54 UTC

window: make Alt-Down behavior symmetric to Alt-Up

Previously Alt-Down was an alternative to Enter. It opened folders and
files. All other Alt-[arrow key] combinations only navigate, so opening
of files was strange behavior for a navigation shortcut. Similarly,
Alt-Down and Alt-Up did not form a symmetric pair, like Alt-Left and
Alt-Right.

So to create the symmetry, change Alt-Down to navigate into previously
opened folders, if those folders reside in the current location. This
allows for a new way of easily navigating up to a parent folder with
Alt-Up and quickly navigating back to the previous location with
Alt-Down, without risking to overshoot beyond the desired location,
as e.g. navigation with Alt-Left can cause.

wip/antoniof/arrays-rule-rebased-on-unchecked-eel 2023-10-29 18:19:45 UTC
file: Drop deep ref/unref wrappers

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2023-07-22 15:20:46 UTC

file: Drop deep ref/unref wrappers

Their names are misleading: the list itself is not refcounted.

This misconception is likely how some memory leaks have been
introduced in nautilus_restore_files_from_trash() and in
properties_cb(). Both leaks are therefore fixed as part of
this commit by employing autocleanup in the first case and
stack allocation in the second case.

wip/p3732/dnd-fixes-sidebar 2023-09-17 07:13:24 UTC
sidebar-row: don't explicitly clone NautilusFile

Author: Peter Eisenmann
Author Date: 2023-09-17 06:36:08 UTC

sidebar-row: don't explicitly clone NautilusFile

The "file" property is read-only, as it is handled via the "uri"
property. There is no need to set it, it causes warnings.

Fixes first part of #3103

wip/corey/thumbnail-large 2023-08-26 16:23:44 UTC
thumbnail: Use new glib attributes to get the thumbnails for x/xx large

Author: Corey Berla
Author Date: 2022-09-29 21:28:53 UTC

thumbnail: Use new glib attributes to get the thumbnails for x/xx large

When in the introduction of x-large and xx-large thumbnails in
278435e3c20244b48986c6cd8b72c5317668c72d, we no longers retrieved the
thumbnails correctly, because glib/gio was only looking for normal and
large thumbnail paths.

glib!2918 introduces new attributes for x-large and xx-large
thumbnails paths. Produce the correct file attribute depending
on the size thumbnail we are generating.
https://gitlab.gnome.org/GNOME/glib/-/merge_requests/2918/

gbsneto/cleanup-unused-variables 2023-08-21 16:12:44 UTC
toolbar: Don't override GObjectClass.dispose

Author: Georges Basile Stavracas Neto
Author Date: 2023-08-21 16:12:44 UTC

toolbar: Don't override GObjectClass.dispose

NautilusToolbar does not do, and does not *need to* do anything
on dispose right now, so overriding GObjectClass.dispose just to
chain up is useless.

Stop overriding GObjectClass.dispose.

wip/antoniof/global-search 2023-08-04 21:40:43 UTC
toolbar: Always show search bar in global search

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2023-08-04 21:23:45 UTC

toolbar: Always show search bar in global search

And hide its the toggle button, as per design.

The global search will be accessible from a new button when the new
design is implemented. For now, it can be accessed by entering its
URI: x-nautilus-global-search:///

Part of https://gitlab.gnome.org/GNOME/nautilus/-/issues/3013

wip/cdavis/toggle-groups 2023-07-29 21:28:00 UTC
search-popover: Use AdwToggleGroup

Author: Christopher Davis
Author Date: 2023-07-29 21:28:00 UTC

search-popover: Use AdwToggleGroup

libadwaita provides a new widget for exclusive toggles that
we can use in place of our linked styling that we were using
previously. AdwToggleGroup handles displaying the buttons,
icons, and tooltips in a nice, compact, and accessible widget.

Requires https://gitlab.gnome.org/GNOME/libadwaita/-/merge_requests/727

antoniof/search-location-captions 2023-07-29 11:14:31 UTC
grid-cell: Show location as a caption in search & friends

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2023-06-16 19:22:42 UTC

grid-cell: Show location as a caption in search & friends

Search results from subfolders are the main challenge with using grid
view for search results. For these results, we need to show the path
in order to differentiate between otherwise identical results.

Show the path as a caption for search and, for consistency, also for
the other special locations where list view shows a path.

Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2969

wip/corey/ext-manager 2023-07-18 21:29:24 UTC
general: Stop bundling nautilus-module in the main application

Author: Corey Berla
Author Date: 2023-07-18 21:19:38 UTC

general: Stop bundling nautilus-module in the main application

wip/corey/ext-cleanup 2023-07-17 18:31:46 UTC
libnautilus-extension: Reformat documentation

Author: Corey Berla
Author Date: 2023-07-17 18:31:46 UTC

libnautilus-extension: Reformat documentation

Our current documentation is really poor. Almost all of the short
descriptions are missing (or poorly formatted). Most of the links
are incorrectly formatted. Some methods/properties/signals are
missing documentation altogether. Since I am changing the
documentation so extensively, move it to the .c files
which is the correct location (so the links can be properly created
to the gitlab source).

wip/corey/more-eel 2023-07-12 22:22:07 UTC
eel: Use GString instead of eel_str_replace_substring

Author: Corey Berla
Author Date: 2023-07-12 21:31:46 UTC

eel: Use GString instead of eel_str_replace_substring

g_string_replace() provides the same functionality. Let's leave
the existing function names to save a few lines of reuse.
eel_str_double_unscores() is also just a specific use case of
eel_str_replace_substring.

gsoc-2022 2023-07-12 12:03:14 UTC
files-view: Allow creating new files

Author: Ignacy Kuchciński
Author Date: 2022-08-01 20:01:05 UTC

files-view: Allow creating new files

wip/corey/sushi-handle 2023-07-01 20:56:12 UTC
previewer: Respond to selection events on actual window

Author: Corey Berla
Author Date: 2023-07-01 20:56:12 UTC

previewer: Respond to selection events on actual window

SelectionEvent's (pushing arrow keys from the previewer window), are
emitted to all subscribers of the signal. When there's one instance
of Nautilus with a single window, this is not a problem. But when
there's multiple instances (i.e. Nautilus nightly and Nautilus, or
another subscriber to NautilusPreviewer2), the SelectionEvents
get consumed by all subscribers even though they probably don't
expect it.

This issue can be solved with the new ParentHandle property of
NautilusPreviewer2 which returns the parent window of the previewer
window. Only respond to the SelectionEvent if the ParentHandle
exists in this instance of Nautilus.

wip/antoniof/tracker-domain-argument 2023-06-17 16:35:57 UTC
fix-test

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2023-06-17 16:15:27 UTC

fix-test

wip/antoniof/threshold-adjustment 2023-06-14 21:01:15 UTC
Update nautilus-window.ui

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2023-06-14 21:01:15 UTC

Update nautilus-window.ui

wip/corey/search-popover 2023-06-08 19:58:46 UTC
mime-actions: Make video audio mime types more comprehensive

Author: Corey Berla
Author Date: 2023-01-07 18:56:46 UTC

mime-actions: Make video audio mime types more comprehensive

Use the list from totem which presumably is pretty comprehensive.
This could have a performance impact on tracker, but it doesn't
seem noticeable from my testing.

Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2452

wip/corey/more-list-vieww 2023-06-05 19:19:06 UTC
file: Use g_strv_equal() from glib

Author: Corey Berla
Author Date: 2023-06-05 19:19:06 UTC

file: Use g_strv_equal() from glib

Our private method is a relic of eel

cherry-pick-1ff51f9d-2 2023-05-04 21:18:30 UTC
name-cell: Clear loading timeout on finalize

Author: Corey Berla
Author Date: 2023-04-30 15:14:38 UTC

name-cell: Clear loading timeout on finalize

Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2882

(cherry picked from commit 1ff51f9dd410921f6b9a89f74244218e4d225c1a)

cherry-pick-1ff51f9d 2023-05-04 21:17:09 UTC
name-cell: Clear loading timeout on finalize

Author: Corey Berla
Author Date: 2023-04-30 15:14:38 UTC

name-cell: Clear loading timeout on finalize

Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2882

(cherry picked from commit 1ff51f9dd410921f6b9a89f74244218e4d225c1a)

wip/corey/selection-43 2023-04-13 23:35:07 UTC
list-view: Drop selection click workaround

Author: Corey Berla
Author Date: 2023-04-13 23:35:07 UTC

list-view: Drop selection click workaround

There was an issue selecting using ctrl+select which was fixed in
GTK. Our workaround is now making it break.

Related: gtk#5669

wip/antoniof/null-date-from-tracker 2023-04-08 21:41:58 UTC
search-engine-tracker: Don't try to parse NULL time strings

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2023-04-08 21:41:58 UTC

search-engine-tracker: Don't try to parse NULL time strings

TrackerCursor returns NULL if it doesn't have information on the date.
https://gnome.pages.gitlab.gnome.org/tracker/docs/developer/method.SparqlCursor.get_string.html

We try to parse NULL as a date string. This is obviously wrong and
gets us a precondition failure warning, as it should.

So, if a string is NULL, just skip it.

Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2160

revert-049bfe97 2023-04-08 02:36:32 UTC
Revert "grid-cell, name-cell: Don't add missing emblems"

Author: Corey Berla
Author Date: 2023-04-08 02:36:32 UTC

Revert "grid-cell, name-cell: Don't add missing emblems"

This reverts commit 049bfe9792e2ec6d0c435a8baa89bb81d2769ed4

gnome-42 2023-02-07 13:33:58 UTC
view-icon-item-ui: Fix style for updated version of uncrustify

Author: Ondrej Holy
Author Date: 2023-02-07 13:33:58 UTC

view-icon-item-ui: Fix style for updated version of uncrustify

The updated version of uncrustify doesn't like this style.

wip/antoniof/completion-priority-high 2022-12-25 02:47:31 UTC
take_3

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2022-12-25 01:13:44 UTC

take_3

wip/corey/gesture-fix 2022-11-18 05:18:35 UTC
list-base: Set view longpress to GTK_PHASE_CAPTURE

Author: Corey Berla
Author Date: 2022-10-08 04:02:48 UTC

list-base: Set view longpress to GTK_PHASE_CAPTURE

There's an issue with how GtkGestureLongPress functions where if the
gesture is in phase BUBBLE and another gesture in CAPTURE claims
the sequence, the prior LongPress will emit a ::pressed event
regardless. More specifically, our code doesn't work because the
drag gesture in GtkListBase (which tracks if rubberband should be
stopped) prevent events from being sent to our view long press gesture.
This makes the background menu pop-up unexpectedly while dragging
on a touchscreen.

Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2616

wip/corey/touch-double-click 2022-10-10 20:43:29 UTC
list-base: Handle double click with touchscreen

Author: Corey Berla
Author Date: 2022-10-10 20:43:29 UTC

list-base: Handle double click with touchscreen

We override the double click in nautilus-list-base but only
have a case for GDK_BUTTON_PRIMARY. If gtk_gesture_single_get_current_button()
doesn't return a button, assume it's the pimary button.

Fixes: https://gitlab.gnome.org/GNOME/nautilus/-/issues/2538

wip/antoniof/use-gtk-widget-dispose-template 2022-09-03 19:16:40 UTC
WIP general: Use gtk_widget_dispose_template

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2022-09-03 19:15:41 UTC

WIP general: Use gtk_widget_dispose_template

Resolves https://gitlab.gnome.org/GNOME/nautilus/-/issues/2418

wip/corey/dnd_features 2022-09-01 21:42:41 UTC
dnd: Remove already removed code from headers

Author: Corey Berla
Author Date: 2022-08-18 20:35:01 UTC

dnd: Remove already removed code from headers

wip/corey/list-base-click 2022-08-24 03:32:31 UTC
list-base: Make view click pressed event controller better

Author: Corey Berla
Author Date: 2022-08-24 03:32:31 UTC

list-base: Make view click pressed event controller better

Our view click handling has an unnecessary workaround to deal with
the propagation from item clicks. We set the flag deny_background_click
when an item is clicked, and then clear it on release/stop. This is a
little hard to follow and I think might be contributing to problems
such a quasi-activated state for some items.

Set the propagation phase to TARGET on the view. This works out of the
box for the GridView. ColumnView is implemented using a child
ListView, so we have to get that by looking at the child's silbing.

wip/jimmac/grid-view-shadows-composited 2022-08-03 10:21:26 UTC
grid view: icon/thumbnail shadows

Author: jimmac
Author Date: 2022-08-03 09:52:16 UTC

grid view: icon/thumbnail shadows

Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2255

wip/antoniof/three-menus-no-more 2022-08-01 01:13:19 UTC
toolbar-view-menu.ui: Move into files-view.ui

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2022-07-31 23:04:31 UTC

toolbar-view-menu.ui: Move into files-view.ui

This is not used by the toolbar anymore and this is much simpler.

wip/cdavis/use-status-page 2022-07-17 18:25:21 UTC
files-view: Add empty state for Recent

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2022-07-17 18:14:44 UTC

files-view: Add empty state for Recent

wip/antoniof/a-few-header-cleanups 2022-07-11 00:18:18 UTC
toolbar: Remove unused functions

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2022-07-11 00:18:18 UTC

toolbar: Remove unused functions

gnome-41 2022-05-11 00:33:46 UTC
flatpak: Pin gnome-desktop to stable branch

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2022-04-22 22:03:52 UTC

flatpak: Pin gnome-desktop to stable branch

The master branch introduces incompatible API changes in the
thumbnailing component.

The previously cherry-picked patch has been reverted because
it shouldn't have been applied to the stable branch.

Instead, in order to pass the pipeline, use stable dependency.

Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/2237

(cherry picked from commit ca306b56d9f72afd60f515f311ed14bf95fdb028)

gnome-3-36 2022-03-10 14:46:01 UTC
Update Norwegian Bokmål translation

Author: Kjartan Maraas
Author Date: 2022-03-10 14:46:01 UTC

Update Norwegian Bokmål translation

2161-laggy-scrolling-with-adwaita-theme 2022-02-28 18:27:24 UTC
canvas-item: Use 0px border-radius for thumbnails

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2022-02-28 14:39:29 UTC

canvas-item: Use 0px border-radius for thumbnails

The border-radius intended for drawing the selection rectangle around
labels is also causing black artifacts in the corners of thumbnails.

This was not noticeable before because thumbnails had a rounded frame.

So, set the radius to 0 when drawing the thumbnails, but restore the
radius for the labels.

origin/2070-menu-item-re-organization 2022-01-10 13:07:37 UTC
cut_copy_not_horizontal

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2022-01-10 13:07:37 UTC

cut_copy_not_horizontal

gtk4-preparation-trunk 2022-01-01 22:04:06 UTC
general: Stop using GtkWidget::popup-menu

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2022-01-01 19:50:09 UTC

general: Stop using GtkWidget::popup-menu

The signal is gone in GTK 4.

Replace the most relevant use with an action and a keyboard accelerator.

abderrahim/libportal 2021-12-25 15:29:44 UTC
general: Add libportal-gtk3 dependency

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2021-12-21 17:42:27 UTC

general: Add libportal-gtk3 dependency

The portal-gtk3.h header has been moved into a separate library which
binds gtk3 explicitly.

https://github.com/flatpak/libportal/pull/53

wip/exalm/dark 2021-12-11 13:16:37 UTC
application: Support dark preference

Author: Alexander Mikhaylenko
Author Date: 2021-12-11 13:01:23 UTC

application: Support dark preference

wip/antoniof/try-admin-backend-for-file-ops 2021-11-27 21:25:45 UTC
[Commit message is WIP]

Author: Sachin Daluja
Author Date: 2021-06-16 03:02:37 UTC

[Commit message is WIP]

file-operations: Try admin backend for file ops

When the user does not have sufficient permissions.

Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1282
Closes https://gitlab.gnome.org/GNOME/nautilus/-/issues/257

gnome-40 2021-11-03 17:24:16 UTC
Update Brazilian Portuguese translation

Author: Rafael Fontenelle
Author Date: 2021-11-03 17:24:16 UTC

Update Brazilian Portuguese translation

1889-file-conflict-ok-button-label-is-rename-instead-of-replace 2021-10-26 12:29:34 UTC
file-conflict-dialog: Don't change action when unchecking

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2021-07-24 19:00:14 UTC

file-conflict-dialog: Don't change action when unchecking

The "Apply this action to all files and folders" checkbox works only
with the "Replace" action, not the "Rename" action. Indeed, if the
rename field is expanded, the checkbox is greyed out.

However, if the checkbox is checked, when unchecking it changes the
main action to Rename, despite the rename field being obviously
hidden (otherwise the checkbox wouldn't be checked). That's wrong.
It's a regression from 15d59cd18de13b1c09dae1fe07102e213cdd9fd4

When the checkbox is unchecked, the action is already "Replace", so
there is no need to change it.

Fixes https://gitlab.gnome.org/GNOME/nautilus/-/issues/1889

wip/jimmac/icon-source 2021-06-29 12:35:11 UTC
icon: add 'source'

Author: jimmac
Author Date: 2021-06-29 12:31:25 UTC

icon: add 'source'

Initiative: https://gitlab.gnome.org/Teams/Design/initiatives/-/issues/84

previewer-track-currently-open-file 2021-05-25 14:56:09 UTC
nautilus-previewer: Only launch previewer when file URI changes

Author: Felipe Borges
Author Date: 2021-05-25 14:56:09 UTC

nautilus-previewer: Only launch previewer when file URI changes

There's a race condition for when Nautilus checks for Sushi's
"Visible" property and decides whether a selection change should
update the previewed file.

By avoiding calling Sushi when the selected file is the same as
the last one previewed, we can workaround the race condition.

Fixes #1823

gnome-3-38 2021-03-07 19:47:58 UTC
Update Turkish translation

Author: =?utf-8?q?Emin_Tufan_=C3=87etin?=
Author Date: 2021-03-07 19:47:58 UTC

Update Turkish translation

wip/cdavis/adaptive-flap 2021-02-22 12:48:30 UTC
Move NautilusAdaptiveMode to nautilus-ui-utilities.h

Author: Christopher Davis
Author Date: 2020-12-26 05:45:31 UTC

Move NautilusAdaptiveMode to nautilus-ui-utilities.h

wip/antoniof/template-leaks 2020-12-19 18:53:13 UTC
toolbar: Don't leak builder object

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2020-12-19 17:12:18 UTC

toolbar: Don't leak builder object

Leak found in valgrind file provided by nekohayo

barthalion/ci-rawhide 2020-12-11 12:47:02 UTC
Revert "ci: Use Fedora latest instead of rawhide temporarily"

Author: =?utf-8?q?Bart=C5=82omiej_Piotrowski?=
Author Date: 2020-12-11 12:47:02 UTC

Revert "ci: Use Fedora latest instead of rawhide temporarily"

GNOME CI runners have been updated to the latest libseccomp so the
problem should no longer happen.

This reverts commit ab55380f200e5ea03116c5871607d125deff844c.

wip/antoniof/nobody-changes-timezone-that-fast 2020-09-19 20:26:38 UTC
general: Rate limit local time zone reads

Author: =?utf-8?q?Ant=C3=B3nio_Fernandes?=
Author Date: 2020-09-17 23:21:06 UTC

general: Rate limit local time zone reads

1100 of 170 results

Other repositories

You can't create new repositories for Nautilus.