Code review comment for lp:~larsu/gsettings-qt/lp1503693

Revision history for this message
Albert Astals Cid (aacid) wrote :

any reason you removed the signalspy? i think it's good checking that reset does actually trigger the signal too, proves that qml will re-evaluate things that depend on it, something like

    changesSpy.clear();
    settings.schema.reset('testInteger');
    tryCompare(changesSpy, "count", 1);

What do you think?

review: Needs Information

« Back to merge proposal