lp:~larsu/gsettings-qt/lp1503693
- Get this branch:
- bzr branch lp:~larsu/gsettings-qt/lp1503693
Branch merges
- Albert Astals Cid (community): Approve
-
Diff: 49 lines (+16/-2)2 files modifiedGSettings/gsettings-qml.cpp (+13/-1)
tests/tst_GSettings.qml (+3/-1)
Related bugs
Related blueprints
Branch information
Recent revisions
- 75. By Lars Karlitski
-
qml tests: put changesSpy back
To check that the signal gets emitted when a key is reset.
- 74. By Lars Karlitski
-
qgsettings-qml: explicitly emit changed events
We're working around QTBUG-32859 by not dispatching changed signals
directly. This leads to two issues:1. Changed signals are not emitted by GSettingsQml, because it only
emits those when the value is different from its cached one, which is
already updated by the time the queued signal arrives.2. Calling schema.reset() from qml and immediately fetching the value
after returns the old value, because the value was only updated when the
signal arrives.Fix these by explicitly emitting the changed signal when setting the
value from qml (the later one is then ignored) and setting the cached
value when calling reset().Also, remove changesSpy from test_reset(), because that now counts
changes correctly and includes the ones from previous tests.This patch can be reverted once the Qt bug is fixed.
- 72. By Lukáš Tinkl
-
Force handling deferred delete events to avoid memory leaks Fixes: #1460970
Approved by: Nick Dedekind, Lars Uebernickel
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:gsettings-qt