Merge ~larsks/cloud-init:bug/1354694 into cloud-init:master

[Lars Kellogg-Stedman]

The documentation shows group names in the 'groups:' key delimited by ", ", but this will result in group names that contain spaces. This can cause the 'groupadd' or 'useradd' commands to fail.

This patch ensures that we strip whitespace from either end of the group names passed to the 'groups:' key.

[Scott Moser (smoser)]

I've re-opened the bug, unfortunately the change here didnt fix the issue all the way.

diff --git a/cloudinit/distros/__init__.py b/cloudinit/distros/__init__.py
index 4a72643..1f73195 100755
--- a/cloudinit/distros/__init__.py
+++ b/cloudinit/distros/__init__.py
@@ -403,7 +403,7 @@ class Distro(object):
                 # that can go right through to the command.
                 kwargs['groups'] = ",".join(groups)
             else:
-                groups = groups.split(",")
+                groups = [group.strip() for group in groups.split(",")]
 
             primary_group = kwargs.get('primary_group')
             if primary_group: