Code review comment for lp:~laney/apport/no-yalign

Revision history for this message
Iain Lane (laney) wrote :

On Fri, Jun 05, 2015 at 09:40:22PM -0000, Martin Pitt wrote:
> Review: Approve
>
> Merged with a NEWS entry, thanks! For the wily upload it would be nice if you could push the GTK dependency as this doesn't look backwards compatible. (Not necessary to upload for just this, though.)

I didn't verify, but the documentation says "Since: 3.0"

  https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--valign

they only deprecated yalign this cycle, though. So seems it doesn't need
bumping?

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

« Back to merge proposal