Merge lp:~laney/apport/no-yalign into lp:~apport-hackers/apport/trunk

[Iain Lane]

This fixes a testsuite failure (fatal warnings) with gtk 3.16.

I'm going to upload it, but feel free to clobber with a better fix if you want.

[Martin Pitt (pitti)]

Merged with a NEWS entry, thanks! For the wily upload it would be nice if you could push the GTK dependency as this doesn't look backwards compatible. (Not necessary to upload for just this, though.)

review: Approve

[Iain Lane (laney)]

On Fri, Jun 05, 2015 at 09:40:22PM -0000, Martin Pitt wrote:
> Review: Approve
>
> Merged with a NEWS entry, thanks! For the wily upload it would be nice if you could push the GTK dependency as this doesn't look backwards compatible. (Not necessary to upload for just this, though.)

I didn't verify, but the documentation says "Since: 3.0"

  https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--valign

they only deprecated yalign this cycle, though. So seems it doesn't need
bumping?

--
Iain Lane [ <email address hidden> ]
Debian Developer [ <email address hidden> ]
Ubuntu Developer [ <email address hidden> ]

[Martin Pitt (pitti)]

Iain Lane [2015-06-08 10:39 -0000]:
> I didn't verify, but the documentation says "Since: 3.0"
>
> https://developer.gnome.org/gtk3/stable/GtkWidget.html#GtkWidget--valign
>
> they only deprecated yalign this cycle, though. So seems it doesn't need
> bumping?

Ah, perfect. Thanks for verifying!

=== modified file 'gtk/apport-gtk.ui'
--- gtk/apport-gtk.ui	2015-02-28 20:09:01 +0000
+++ gtk/apport-gtk.ui	2015-06-05 10:54:20 +0000
@@ -130,7 +130,7 @@
               <object class="GtkImage" id="application_icon">
                 <property name="visible">True</property>
                 <property name="can_focus">False</property>
-                <property name="yalign">0</property>
+                <property name="valign">start</property>
                 <property name="icon-name">dialog-error</property>
                 <property name="icon-size">6</property>
               </object>