Code review comment for ~lamoura/ubuntu/+source/update-notifier:update-notifier-esm-support

Revision history for this message
Bryce Harrington (bryce) wrote :

Fixes look good, thanks, and I've verified the tests pass and did a local smoke test.

Tagged and uploaded for xenial:

triage-xenial+16.04:~/pkg/UpdateNotifier/review-mp401473$ dput -f ubuntu update-notifier_3.168.14_source.changes
Checking signature on .changes
gpg: Signature made Tue 27 Apr 2021 12:50:46 AM UTC using RSA key ID 8FB8F0FB
gpg: Good signature from "Bryce Harrington <email address hidden>"
gpg: aka "Bryce Harrington <email address hidden>"
gpg: aka "Bryce Harrington <email address hidden>"
Good signature on /home/bryce/pkg/UpdateNotifier/review-mp401473/update-notifier_3.168.14_source.changes.
Checking signature on .dsc
gpg: Signature made Tue 27 Apr 2021 12:50:46 AM UTC using RSA key ID 8FB8F0FB
gpg: Good signature from "Bryce Harrington <email address hidden>"
gpg: aka "Bryce Harrington <email address hidden>"
gpg: aka "Bryce Harrington <email address hidden>"
Good signature on /home/bryce/pkg/UpdateNotifier/review-mp401473/update-notifier_3.168.14.dsc.
Uploading to ubuntu (via ftp to upload.ubuntu.com):
  Uploading update-notifier_3.168.14.dsc: done.
  Uploading update-notifier_3.168.14.tar.xz: done.
  Uploading update-notifier_3.168.14_source.changes: done.
Successfully uploaded packages.

triage-xenial+16.04:~/pkg/UpdateNotifier/review-mp401473/update-notifier-gu$ git ubuntu tag -f --upload
/snap/git-ubuntu/current/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
Updated tag 'upload/3.168.14' (was 1f8fcad)
triage-xenial+16.04:~/pkg/UpdateNotifier/review-mp401473/update-notifier-gu$ git push -f pkg upload/3.168.14
Counting objects: 17, done.
Delta compression using up to 12 threads.
Compressing objects: 100% (17/17), done.
Writing objects: 100% (17/17), 2.97 KiB | 0 bytes/s, done.
Total 17 (delta 13), reused 0 (delta 0)
To ssh://<email address hidden>/ubuntu/+source/update-notifier
 + 1f8fcad...7474f3b upload/3.168.14 -> upload/3.168.14 (forced update)

I had to force push since the previous MP upload was already in place. I'm assuming the previous upload was pulled early enough we don't have to re-rev the version numbers; if not we'll know soon enough...

review: Approve

« Back to merge proposal