~lamoura/ubuntu/+source/update-notifier:update-notifier-esm-support

Branch merges

Propose for merging

Merged into ubuntu/+source/update-notifier:ubuntu/xenial-devel at revision 0b7f4623663af8a03c5217cf78c58e7d73a605cd

Bryce Harrington (community): Approve on 2021-04-27

Diff: 903 lines (+533/-149)

4 files modified

data/apt_check.py (+195/-82)
debian/changelog (+15/-0)
debian/control (+2/-0)
tests/test_motd.py (+321/-67)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related charm recipes

0b7f462... by Lucas Albuquerque Medeiros de Moura on 2021-04-20

Add changelog for release 3.168.14

d768e78... by Lucas Albuquerque Medeiros de Moura on 2021-04-26

apt_check: use applied instead of installed. correct singular msg

44c3b39... by Lucas Albuquerque Medeiros de Moura on 2021-04-26

Separate security updates from esm updates

Currently, we display packaging count for both ESM
and security updates. However, if the package upgrade
comes from ESM, we still count it as a security update.
This can provide confusing messages to users, since
we don't say in that message that security updates contain
both source of packages. To better handle that, we are
now only treating as security updates only security upgrades
that are not related to ESM packages. To further make that
distinction, we are updating the message to show
standard security updates instead of just security updates

10d0943... by Lucas Albuquerque Medeiros de Moura on 2021-04-20

Update apt-check script for ESM Apps handling

Currently, the apt-check script is configured to only handle
package count for ESM Infra. We are now updating the logic
to also handle ESM Apps packages as well.

Furthermore, we are also updating the messaging that
is created in apt-check. We are advertising ESM Apps if the
service is disabled and only messaging about ESM Infra if the
distro is already on ESM mode

40b2c47... by Chad Smith on 2020-12-10

changelog

4512589... by Chad Smith on 2020-12-11

tests/test_package-data-downloader: avoid integration error messages

The unit tests of package-data-downloader expect 404 failures running
against a SimpleHTTPServer in unit tests for "not-here.txt". This results
in stderr messages to console that look like test errors:

Err:1 http://localhost:59320/not-there.txt
  403 Forbidden file type or location
E: Failed to fetch http://localhost:59320/not-there.txt 403 Forbidden file

These are not actually test failures, but emitting them in the test
logs leads to confusion when reviewing the test runs.

Unit tests probably shouldn't be running integration testing anyway.
Instead mock subprocess.call on these tests to avoid raising confusing
error messages to console.

a59bb88... by Chad Smith on 2020-12-10

d/control d/tests/control: move pep8 dependency into autopkgtest control

pep8 is only referenced by tests/test_pep8.py via subprocess due to the
autopkgtest nosetests3.

The pep8 pkg is removed from Build-Depends because it is not
needed for package build which only runs the following during build:
python3 test_package-data-downloader.py

LP: #1906436

4a79146... by Chad Smith on 2020-12-02

d/control: add explicit pep8 build-requires dependency

LP: #1906436

ccc8096... by Chad Smith on 2020-12-02

data/apt_check.py: fix over-indent pep8 errors

LP: #1906436

8195c7c... by Chad Smith on 2020-11-30

Fix E117 over-indented pep issues. backport of f881447e2