Code review comment for lp:~ksamak/compiz/add_startup_option_to_negative

Revision history for this message
ksamak (ksamak) wrote :

> If this is the wanted behavior change the name of the option otherwise this
> does not look correct to me.

I now fixed the indent.

The original wanted behaviour is the start-up mechanism. it has been requested by 3v1n0 that the option has an effect when ticked, to show that it's been taken into account.

If first did with a timer, but i changed it to this "workaround", and it does fulfil both these requirements.

The only interest of this is the activation of negative windows at start up, so i do not see a semantic problem with the naming, but maybe I'm missing something.

review: Approve

« Back to merge proposal