Merge lp:~ksamak/compiz/add_startup_option_to_negative into lp:compiz/0.9.13

[ksamak]

neg: added hook to react to change in ccsm, for autostart option

neg: added hook to react to change in ccsm, for autostart option

[Sam Spilsbury (smspillaz)]

review: Needs Fixing

[Sam Spilsbury (smspillaz)]

> optionSetActivateAtStartupNotify (boost::bind (&NegScreen::optionChanged, this,
> _1, _2));

This is also incorrect - it will cause all windows to be toggled whenever the option is changed, not just on startup.

[ksamak (ksamak)]

> > optionSetActivateAtStartupNotify (boost::bind (&NegScreen::optionChanged,
> this,
> > _1, _2));
>
> This is also incorrect - it will cause all windows to be toggled whenever the
> option is changed, not just on startup.

Yes, this is a suggestion made by 3v1n0, that when the user switches this option in ccsm, he sees a immediate reaction. This ensures the user that changes have been taken into account
This switches all windows immediately indeed. Though i can think of no case where it is irrelevant.

[Marco Trevisan (Treviño) (3v1n0)]

You need to fix indentation...

[Andrea Azzarone (azzar1)]

If this is the wanted behavior change the name of the option otherwise this does not look correct to me.

review: Needs Fixing

[lp:~ksamak/compiz/add_startup_option_to_negative]

4108. By ksamak <ksamak@ksalaptop> on 2017-08-24

fixed indent

[ksamak (ksamak)]

> If this is the wanted behavior change the name of the option otherwise this
> does not look correct to me.

I now fixed the indent.

The original wanted behaviour is the start-up mechanism. it has been requested by 3v1n0 that the option has an effect when ticked, to show that it's been taken into account.

If first did with a timer, but i changed it to this "workaround", and it does fulfil both these requirements.

The only interest of this is the activation of negative windows at start up, so i do not see a semantic problem with the naming, but maybe I'm missing something.

review: Approve

[Marco Trevisan (Treviño) (3v1n0)]

Let's go with this...

review: Approve

=== modified file 'plugins/neg/src/neg.cpp'
--- plugins/neg/src/neg.cpp	2016-11-03 09:09:57 +0000
+++ plugins/neg/src/neg.cpp	2017-08-24 13:55:10 +0000
@@ -427,7 +427,17 @@
 			if (NegWindow::get (w)->isNeg)
 				NegWindow::get (w)->cWindow->addDamage ();
 	}
-    default:
+	break;
+	case NegOptions::ActivateAtStartup:
+	{
+	    isNeg = optionGetActivateAtStartup();
+	    foreach (CompWindow *w, screen->windows ())
+	    {
+		NEG_WINDOW (w);
+		nw->toggle ();
+	    }
+	}
+	default:
 	break;
     }
 }
@@ -453,6 +463,8 @@
 					      _1, _2));
 	optionSetNegDecorationsNotify (boost::bind (&NegScreen::optionChanged, this,
 					  _1, _2));
+    optionSetActivateAtStartupNotify (boost::bind (&NegScreen::optionChanged, this,
+						   _1, _2));
 
 }