Code review comment for lp:~kokoto-java/checkbox/new-QT-home-screen

Revision history for this message
George Karavasilev (kokoto-java) wrote :

A bit of feedback about the MR:
 - "Confirm" as a button label is just wrong. "Continue" sounds much better name for that button. That's a 1 second fix.
 - The checkbox "Don't show me this message again" shouldn't start with "Don't", however changing the label to "Show me this message again" would change the behaviour of the home screen, because if the use doesn't check that checkboc he won't be able to see the homescreen again. This is a seperate bug and somebody must change the behaviour of the checkbox and the UI. This is most likely not to be implemented in this MR.
 - The banner outline should be killed off (And I'm not sure that's even possible, but then again after my after this MR is merged someone can try playing w/ it and fix it. BTW: that outline is here even know, it is just the current banned is light and the light outline is not that visible)
 - Mking the "System Testing" string translatable will be next to impossible with the current banner design (it would require either a banner redesign and it won't be that pretty after it or some incredibly ugly hack in the UI code that will be ... well, incredibly ugly) and to be fair I'm not sure it is that needed, because the titlebar does say "System Testing")

« Back to merge proposal